Repository navigation
Conversation
Fixes the 15 actions/unpinned-tag code-scanning alerts in docker-publish.yml, docker-publish-skdb.yml and docker-retag-latest.yml: docker/setup-buildx-action -> v4.4.1, docker/login-action -> v4.8.0, docker/bake-action -> v7.5.0. First-party actions/* and github/* uses are trusted by code scanning and left on tags. Co-Authored-By: Mistral Vibe (mistral-large-4-0) <vibe@mistral.ai> Co-authored-by: mbouaziz <mbouaziz@users.noreply.github.com>
Fixes the js/missing-origin-check code-scanning alert on the postmessage handler in skdb_worker.ts. The worker is only created same-origin from the embedding page, so drop messages whose origin does not match the worker script's own origin. Co-Authored-By: Mistral Vibe (mistral-large-4-0) <vibe@mistral.ai> Co-authored-by: mbouaziz <mbouaziz@users.noreply.github.com>
Add .github/codeql/codeql-config.yml and point codeql.yml at it via config-file (the action does not auto-load it). The config keeps the security-extended suite and: - excludes cpp/path-injection: the only hits are the local runtime CLI opening the --data/--init state.db path from its own argv in palloc.c, which the local user already controls; - paths-ignores the localhost-only database-server example, where js/missing-rate-limiting is not exploitable. Config-level filters are the effective mechanism here: GitHub code scanning ignores SARIF suppressions, and in-code codeql[...] comments do nothing unless the AlertSuppression query runs. Co-Authored-By: Mistral Vibe (mistral-large-4-0) <vibe@mistral.ai> Co-authored-by: mbouaziz <mbouaziz@users.noreply.github.com>
|
|
mbouaziz
marked this pull request as ready for review
November 19, 2026 23:53
mbouaziz
enabled auto-merge
November 19, 2026 23:53
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 20 open alerts on https://github.com/SkipLabs/skip/security/code-scanning. The alerts were enumerated by re-running the repo's exact CodeQL matrix (
security-extended, same build modes ascodeql.yml) on a temporary branch and reading the resulting SARIF (the code-scanning REST API is not accessible from this integration).actions/unpinned-tag— the third-party docker actions indocker-publish.yml,docker-publish-skdb.ymlanddocker-retag-latest.ymlare now pinned to commit SHAs (docker/setup-buildx-actionv4.4.1,docker/login-actionv4.8.0,docker/bake-actionv7.5.0). First-partyactions/*/github/*uses are trusted by the query and left on tags.js/missing-origin-check(sql/ts/src/skdb_worker.ts) — the browser worker'smessagehandler now drops events whoseorigindoes not match the worker script's own origin. The worker is only ever created same-origin from the embedding page (new Worker(new URL("./skdb_worker.js", import.meta.url))inbrowser.ts), so this is defense-in-depth with no behavior change for legitimate callers.cpp/path-injection(skiplang/prelude/runtime/palloc.c) — false positive: the only flow is the local runtime CLI opening the--data/--initstate.db path from its own argv. Excluded viaquery-filtersin a new.github/codeql/codeql-config.yml.js/missing-rate-limiting(skipruntime-ts/examples/database-server.ts) — localhost-only example server; excluded viapaths-ignorein the same config file.The config file is wired in through
config-file:incodeql.ymlbecause codeql-action does not auto-load.github/codeql/codeql-config.yml. Config-level filters are the effective mechanism here: GitHub code scanning ignores SARIFsuppressions, and in-codecodeql[...]comments do nothing unless theAlertSuppressionquery is added to the run.Verification
security-extended, same build modes) on this branch via a temporary SARIF-dump workflow: 20 results before, 0 after, across javascript-typescript, python, java-kotlin, c-cpp and actions. The temporary workflow was removed again; this branch contains only the three fix commits. Thesecurity-extendedsuite itself still runs (only the two false-positive rules/paths above are filtered).git ls-remote.Note (unrelated, left untouched): the scheduled
CodeQL Advancedrun'sc-cppjob currently fails on infra — onubuntu-latest(26.04 "resolute")apt.llvm.orghas nollvm-toolchain-resolute-20suite, and the manual runtime build drops-I.fromCFLAGS, soryu/d2s.ccannot findryu/ryu.h.AI disclosure
This PR was prepared with AI assistance (Mistral Vibe, mistral-large-4-0); the commits carry a
Co-Authored-Bytrailer accordingly.