Repository navigation
Fix: on death of an entity never fire - #8968
Open
CrebsTheCoder wants to merge 4 commits into
Open
CrebsTheCoder wants to merge 4 commits into
CrebsTheCoder wants to merge 4 commits into
Conversation
CrebsTheCoder
requested review from
Pesekjak and
cheeezburga
and removed request for
a team
November 11, 2026 17:59
skriptlang-automation
Bot
added
the
needs reviews
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
on death of an entityis rejected and never firesSolution
made entity type check to allow generic entities in death events
Testing Completed
Manual in-game test before & after
Supporting Information
Completes: none
Related: none
AI assistance: none