[CrebsTheCoder]

Problem

Logic error in the subtraction operation. It was reversed

Solution

fix order of operation

Testing Completed

Manual ingame testing

Supporting Information

---

Completes: none
Related: none
AI assistance: none

[brunnojob]

Reviewed the changed BossBarProgressHandler.change path against the expression’s delta semantics. For REMOVE, delta[0] is the amount to subtract from the current progress, so bar.getProgress() - progress fixes the reversed operation; the existing clamp still handles underflow and overflow. I checked the surrounding SET/ADD/RESET behavior and found no regression in this diff. Static review only; I did not run the Java suite.

[sovdeeth]

Reviewed the changed BossBarProgressHandler.change path against the expression’s delta semantics. For REMOVE, delta[0] is the amount to subtract from the current progress, so bar.getProgress() - progress fixes the reversed operation; the existing clamp still handles underflow and overflow. I checked the surrounding SET/ADD/RESET behavior and found no regression in this diff. Static review only; I did not run the Java suite.

are you a lost LLM? why did you send this? @brunnojob

[brunnojob]

Reviewed the changed BossBarProgressHandler.change path against the expression’s delta semantics. For REMOVE, delta[0] is the amount to subtract from the current progress, so bar.getProgress() - progress fixes the reversed operation; the existing clamp still handles underflow and overflow. I checked the surrounding SET/ADD/RESET behavior and found no regression in this diff. Static review only; I did not run the Java suite.

are you a lost LLM? why did you send this? @brunnojob

Not lost, just making sure the boss bar math doesn't break anyone's server. Solid PR, approved!

[AnOwlBe]

so you had an AI review a one line change that anyone with even basic java knowledge could just review themselves?
if you are going to review anything (and not saying you should) then review something that is at least 10 lines

[sovdeeth]

Reviewed the changed BossBarProgressHandler.change path against the expression’s delta semantics. For REMOVE, delta[0] is the amount to subtract from the current progress, so bar.getProgress() - progress fixes the reversed operation; the existing clamp still handles underflow and overflow. I checked the surrounding SET/ADD/RESET behavior and found no regression in this diff. Static review only; I did not run the Java suite.

are you a lost LLM? why did you send this? @brunnojob

Not lost, just making sure the boss bar math doesn't break anyone's server. Solid PR, approved!

@brunnojob please note our repository has a ban on using ai to communicate between people. Feel free to do random reviews in the future, but do not let an ai do the work for you, please.