Extract sampler helpers to utils module and add shared-backend message types#573
Closed
kmontemayor2-sc wants to merge 1 commit intomainfrom
Closed
Extract sampler helpers to utils module and add shared-backend message types#573kmontemayor2-sc wants to merge 1 commit intomainfrom
kmontemayor2-sc wants to merge 1 commit intomainfrom
Conversation
Collaborator
Author
|
/all_test |
Contributor
GiGL Automation@ 17:19:08UTC : 🔄 @ 18:50:45UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 17:19:09UTC : 🔄 @ 18:48:37UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 17:19:11UTC : 🔄 @ 17:26:36UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 17:19:12UTC : 🔄 @ 17:27:33UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 17:19:12UTC : 🔄 @ 18:31:44UTC : ✅ Workflow completed successfully. |
…e types Move _create_dist_sampler() and _prepare_degree_tensors() from dist_sampling_producer.py into a new gigl/distributed/utils/dist_sampler.py module as public functions, along with SamplerInput and SamplerRuntime type aliases. Update dist_sampling_producer.py to import from the new module. Add InitSamplingBackendRequest and RegisterBackendRequest frozen dataclasses to messages.py for the upcoming shared sampling backend. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kmontemayor2-sc
force-pushed
the
kmonte/shared-backend-pr1-helpers
branch
from
b77cdaa to
3b0965c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e types
Move _create_dist_sampler() and _prepare_degree_tensors() from dist_sampling_producer.py into a new gigl/distributed/utils/dist_sampler.py module as public functions, along with SamplerInput and SamplerRuntime type aliases. Update dist_sampling_producer.py to import from the new module.
Add InitSamplingBackendRequest and RegisterBackendRequest frozen dataclasses to messages.py for the upcoming shared sampling backend.
Scope of work done
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO