Repository navigation
feat(skills): add eight skills from the coding-agent skills spec - #29
Jordan Harband (ljharb) wants to merge 1 commit into
Conversation
Add the skills the spec lists as gaps, each grounded in socket@1.14.1 source, Socket Firewall, socket-mcp, and docs.socket.dev: - socket-firewall: run installs through sfw, read and act on a block, Enterprise wrapper and registry modes, CI and Docker. - socket-pr-alerts: triage Socket for GitHub checks and comments, check reachability, then fix, replace, or accept per PR or for good. - socket-reachability: run full application reachability, read .socket.facts.json, and fix reachable vulnerabilities first. - socket-incident-response: confirm a malware report in the threat feed, find usage and dependency paths, check for install-time execution, contain, rotate secrets, and report. - socket-policy: edit socket.yml and change org alert actions, with dry runs where the API supports them. - socket-sbom: generate CycloneDX locally with cdxgen and export CycloneDX or SPDX for an existing scan. - socket-vet-agent-tools: vet an MCP server, skill, or plugin with existing Socket checks before installing it. - knowledge-update: dated corrections for outdated model knowledge about Socket products. Register them in the Claude marketplace (depending on socket-connect where they need an account), the skill discovery test, and the README, and regenerate the agents README and Codex manifest.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit df424d9. Configure here.
| cd "$dir" | ||
| npm init -y | ||
| sfw npm install lodahs | ||
| ``` |
There was a problem hiding this comment.
Firewall test leaves temp working directory
Medium Severity
The “confirm it blocks” steps create a temp directory and cd into it, then never restore the original working directory. Later steps still change project dependencies and rerun installs, so those commands can run against the empty temp project instead of the user’s repo.
Reviewed by Cursor Bugbot for commit df424d9. Configure here.


Adds the eight skills the "Socket Skills for Coding Agents" spec lists as gaps. Each one is a single
skills/<name>/SKILL.md, checked againstsocket@1.14.1source (the current npmlatest; GitHub's "latest release" still points at v1.1.146), Socket Firewall,socket-mcp, and docs.socket.dev.socket-firewallsfw, explains a block and what to do next, and covers Enterprise wrapper and registry modes, CI, and Docker.socket-pr-alertssocket-reachability.socket.facts.json, and fixes reachable vulnerabilities first.socket-incident-responsesocket-policysocket.ymland changes org alert actions, dry-running where the API supports it and asking before any real write.socket-sbomcdxgenand exports CycloneDX or SPDX for an existing scan.socket-vet-agent-toolsknowledge-updateAlso: Claude marketplace entries (all depend on
socket-connectexceptknowledge-update), the skill discovery test's expected list, the README's installable-names line, and the regeneratedagents/README.mdand Codex manifest.Points for review
socket-vet-agent-tools: the spec marks this as needing product confirmation. No Socket product scans an MCP server, skill, or plugin as a unit, so the skill combines existing checks (package scores and alerts, published-file reads, the skills.sh Socket audit, a--no-auto-manifest --tmpscan, install throughsfw) and says so.socket-policyuses an org API token fromSOCKET_CLI_API_TOKENfor the Policies REST API, because the CLI has no Policies command. The skill says this differs from the browser sign-in insocket-connect, dry-runs the endpoints that support it, never prints the token, and asks before the legacy security-policy write, which has no dry run..socket.facts.jsonhas no published schema.socket-reachabilityreads only the fields used in socket-cli's own tests and says the shape may change.Checks
pnpm test: 57 files, 1,376 tests pass. The baseline onmainis 1,264; the increase is the per-skill structural tests.pnpm run checkpasses: format, lint, type, paths, release-kit, shipped content, generate, and scan.socket fixflag that the CLI would silently ignore and then apply fixes.Note
Low Risk
Changes are new agent documentation and marketplace metadata; no runtime application or security-critical code paths are modified.
Overview
Adds eight new agent skills (
socket-firewall,socket-pr-alerts,socket-reachability,socket-incident-response,socket-policy,socket-sbom,socket-vet-agent-tools, andknowledge-update), each as a newskills/<name>/SKILL.mdwith step-by-step workflows aligned to Socket CLI 1.14.x, Firewall, MCP, and current docs.Wiring and discovery are updated so the skills are installable everywhere the repo ships: new entries in
.claude-plugin/marketplace.json(most depend onsocket-connect), the Codex bundle inskills/.codex-plugin/plugin.json, regeneratedagents/README.mdand README skill tables/install name list, and an expandedEXPECTED_TOP_LEVELlist in the skill-discovery structural test.Reviewed by Cursor Bugbot for commit df424d9. Configure here.