Return non-zero exit code when scan report data is not healthy.#986
Merged
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Graydon Hope (graydonhope)
force-pushed
the
unhealthy-report-exit-code
branch
2 times, most recently
from
e858d15 to
9e98037
Compare
John-David Dalton (jdalton)
previously approved these changes
Dec 19, 2025
John-David Dalton (jdalton)
dismissed
their stale review
missed the wrong branch
John-David Dalton (jdalton)
requested changes
Dec 19, 2025
Collaborator
John-David Dalton (jdalton)
left a comment
John-David Dalton (jdalton)
left a comment
There was a problem hiding this comment.
Graydon Hope (@graydonhope) Please implement this against the v1.x branch.
…king alerts were found. This is the expected behaviour based on our docs: https://docs.socket.dev/docs/socket-ci#non-zero-exit-code
Graydon Hope (graydonhope)
force-pushed
the
unhealthy-report-exit-code
branch
from
9e98037 to
c4bcc5c
Compare
Graydon Hope (graydonhope)
requested a review
from John-David Dalton (jdalton)
John-David Dalton (jdalton)
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue where socket ci would exit with code 0 even when
blocking alerts were found.
This is the expected behaviour based on our docs: https://docs.socket.dev/docs/socket-ci#non-zero-exit-code