fix: harden github oauth sign-in flow#1276
Open
ScryUser wants to merge 1 commit into
Open
Conversation
9d9a195 to
7e6d4a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the GitHub OAuth sign-in flow for bounty #821 by removing the 404-prone raw fallback redirects and centralizing sign-in through the auth helper.
Changes include:
VITE_GITHUB_CLIENT_IDwhen the backend authorize endpoint is unavailablesrc/libmodules and narrows the broad.gitignorelib/rule so imported frontend source is trackedCloses #821
Solana Wallet for Payout
Wallet: C2z3FWAacvSYVrrkfpk6nQyNhF4t3z7t9iXRW1xfZPy1
Type of Change
Checklist
console.logor debugging code left behindTesting
npm test -- auth-github-oauth.test.tsxnpm run buildgit diff --checkNotes
I also ran the full
npm testsuite. It currently fails before running most suites because upstream tests import modules that are not present in this repository snapshot, such as../hooks/useAdminData,../components/tokenomics/TokenomicsPage,../components/bounties/BountyBoard, and@playwright/test. The new OAuth-focused test file passes, and the production build passes.