Open
Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…dOS/folder-pane into refactor/styles-separateCSS
There was a problem hiding this comment.
Pull request overview
This PR refactors folderPane styling from inline styles to dedicated CSS files and updates the build setup to accommodate CSS assets.
Changes:
- Move inline styling in
src/folderPane.tsto new CSS files undersrc/styles/and import them from the pane entrypoint. - Add a production webpack config that emits UMD bundles and copies
src/stylesintolib/styles. - Update TS/CSS typing and package metadata to support CSS imports.
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
webpack.config.mjs |
Adds a production build that outputs folder-pane(.min).js and copies CSS assets. |
webpack.module.rules.mjs |
(Context) Confirms .css is global/side-effect and .module.css uses CSS modules. |
package.json |
Switches to ESM package mode, updates main, and marks CSS as side-effectful; adds webpack-related deps. |
package-lock.json |
Locks new dependencies and related transitive updates. |
tsconfig.json |
Includes declarations.d.ts so TS accepts CSS imports during local builds. |
declarations.d.ts |
Adds a TS module declaration for *.css imports. |
src/folderPane.ts |
Replaces inline styles with CSS class usage and imports the new CSS. |
src/styles/folderPane.css |
Introduces pane-specific class styles. |
src/styles/utilities.css |
Adds shared CSS variables (e.g., icon sizing). |
dev/index.js |
Adjusts imports for the dev harness to include extensions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…dOS/folder-pane into refactor/styles-separateCSS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket SolidOS/solidos#244
This has been tested in solid-panes linking to my local folder-pane on this branch.