Skip to content

Mirror new CSS tokens from light.css into dark.css#344

Merged
timea-solid merged 2 commits intoprofileEditA11yfrom
copilot/sub-pr-342
Mar 23, 2026
Merged

Mirror new CSS tokens from light.css into dark.css#344
timea-solid merged 2 commits intoprofileEditA11yfrom
copilot/sub-pr-342

Conversation

Copy link

Copilot AI commented Mar 23, 2026

The parent PR (#342) introduced 17 new CSS custom properties to light.css with no corresponding dark-theme overrides, causing dark mode to silently fall back to light values — producing low-contrast or visually inconsistent UI.

Changes

src/styles/themes/dark.css

  • Borders: --color-border-accent: #9999dd (lightened from light's #8888cc for dark-background contrast)
  • Spacing/Sizing: Added 7 dimension tokens (--spacing-xxxs, --spacing-xxs, --spacing-btn, --border-width-xthin, --border-width-sm, --border-radius-xs, --border-radius-sm) — values match light theme (layout/size, not color)
  • Shadows: Added 6 shadow tokens with elevated opacity for dark-mode legibility:
    --box-shadow-active: 0 1px 2px rgba(124, 77, 255, 0.3);   /* light: 0.2 */
    --box-shadow-focus:  0 0 0 5px rgba(124, 77, 255, 0.35);  /* light: 0.25 */
    --box-shadow-modal:  0 2px 10px rgba(0, 0, 0, 0.5);       /* light: 0.3 */
    /* …overlay, hover, popup similarly adjusted */
  • Overlay: --overlay-bg-muted: rgba(0, 0, 0, 0.5) (vs. 0.3 in light)
  • Misc: --opacity-input-disabled: 0.75, --grid-min-column: 30em (theme-neutral, kept identical)

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

Co-authored-by: timea-solid <4144203+timea-solid@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SolidOS/mashlib/sessions/fc474993-e7a9-44a2-8238-ad3361eb9c58
Copilot AI changed the title [WIP] [WIP] Address feedback on updated CSS variables in original PR Mirror new CSS tokens from light.css into dark.css Mar 23, 2026
Copilot AI requested a review from timea-solid March 23, 2026 09:56
@timea-solid timea-solid marked this pull request as ready for review March 23, 2026 09:57
@timea-solid timea-solid merged commit 2032e76 into profileEditA11y Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants