Camera bar elements#29
Open
logbasem wants to merge 9 commits into
Open
Conversation
…ed Launch and Relaunch buttons, removed Add Camera button
Member
|
wow those linter errors were actually very useful i'll review this shortly :) |
onkoe
approved these changes
May 12, 2026
Member
onkoe
left a comment
onkoe
left a comment
There was a problem hiding this comment.
looks good! just got a few clarity/alert nits to fix when convenient :D
Comment on lines
+177
to
+192
| // IMPORTANT: Calls to the API should only run after this point. | ||
|
|
||
| /* API Requests Example | ||
| // Get the current mode (ex. 1920x1080 @ 30fps) | ||
| let modeResponse = await fetch(`/stream/cameras/${encodeURIComponent(selectedCameraPath)}/modes/current`); | ||
| console.log(await modeResponse.text()); | ||
|
|
||
| // Get the possible modes for the camera (ex. { 0: "1920x1080 @ 30fps", .. }) | ||
| let modesResponse = await fetch(`/stream/cameras/${encodeURIComponent(selectedCameraPath)}/modes`); | ||
| console.log(await modesResponse.json()); | ||
|
|
||
| // Set the current mode for the camera by the index found in the top api request | ||
| let setResponse = await fetch(`/stream/cameras/${encodeURIComponent(selectedCameraPath)}/modes/set/${1}`, { method: "PUT" }); | ||
| console.log(setResponse.status); | ||
| */ | ||
| }; |
Member
There was a problem hiding this comment.
the peerConnection.onicecandidate lambda's scope ends here -- should these comments still be there?
Author
There was a problem hiding this comment.
I wasn't sure since they weren't my comments, if you don't think they're needed I can delete
Co-authored-by: Barrett Ray <66580279+onkoe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI Screenshot