Repository navigation
Holds: fit new holds beside neighbours, keep them through resizes and divides - #48
Merged
Merged
Conversation
… dividers A word resize keeps its holds at their own times like its dividers, trimming one the new span cuts into, and a whole hold whose letter the new spread moves past scales with the word, so a hold is neither stretched across a cut into an invisible ghost nor lost. Moving a word or line shifts its holds by the same sum as its dividers, so a hold ending on one stays on it. Any hold no play honours is dropped when a line is written or the editor opens a map. A tick marks a moment in the song, so resizing a word or dragging a hold edge keeps ticks where they are and drops only those the hold no longer holds. A new hold fits its letter's own subdivision (short syllables, before a cut, next to another hold), dividers and line-box pipes cannot cross a hold, a new divider takes the nearest letter split that keeps every hold, ticks may sit from the hold's head, and a letter's hold-free due time is the aligned era only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
feel free to ping me on dc when this is ready to merge edit: oops sorry i see youve marked as in review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A word resize keeps its holds at their own times like its dividers, trimming one the new span cuts into, and a whole hold whose letter the new spread moves past scales with the word, so a hold is neither stretched across a cut into an invisible ghost nor lost. Moving a word or line shifts its holds by the same sum as its dividers, so a hold ending on one stays on it. Any hold no play honours is dropped when a line is written or the editor opens a map. A tick marks a moment in the song, so resizing a word or dragging a hold edge keeps ticks where they are and drops only those the hold no longer holds. A new hold fits its letter's own subdivision (short syllables, before a cut, next to another hold), dividers and line-box pipes cannot cross a hold, a new divider takes the nearest letter split that keeps every hold, ticks may sit from the hold's head, and a letter's hold-free due time is the aligned era only.
Check the discord thread for the demo. All fixes have been accounted for in there