Skip to content

Holds: fit new holds beside neighbours, keep them through resizes and divides - #48

Merged
Sparpp merged 1 commit into
Sparpp:mainfrom
hehNervii:fix/hold-editor-improvements
Nov 14, 2026
Merged

Sparpp merged 1 commit into
Sparpp:mainfrom
hehNervii:fix/hold-editor-improvements

Conversation

@hehNervii

Copy link
Copy Markdown
Collaborator

A word resize keeps its holds at their own times like its dividers, trimming one the new span cuts into, and a whole hold whose letter the new spread moves past scales with the word, so a hold is neither stretched across a cut into an invisible ghost nor lost. Moving a word or line shifts its holds by the same sum as its dividers, so a hold ending on one stays on it. Any hold no play honours is dropped when a line is written or the editor opens a map. A tick marks a moment in the song, so resizing a word or dragging a hold edge keeps ticks where they are and drops only those the hold no longer holds. A new hold fits its letter's own subdivision (short syllables, before a cut, next to another hold), dividers and line-box pipes cannot cross a hold, a new divider takes the nearest letter split that keeps every hold, ticks may sit from the hold's head, and a letter's hold-free due time is the aligned era only.

Check the discord thread for the demo. All fixes have been accounted for in there

… dividers

A word resize keeps its holds at their own times like its dividers,
trimming one the new span cuts into, and a whole hold whose letter the
new spread moves past scales with the word, so a hold is neither
stretched across a cut into an invisible ghost nor lost. Moving a word
or line shifts its holds by the same sum as its dividers, so a hold
ending on one stays on it. Any hold no play honours is dropped when a
line is written or the editor opens a map. A tick marks a moment in the
song, so resizing a word or dragging a hold edge keeps ticks where they
are and drops only those the hold no longer holds. A new hold fits its
letter's own subdivision (short syllables, before a cut, next to another
hold), dividers and line-box pipes cannot cross a hold, a new divider
takes the nearest letter split that keeps every hold, ticks may sit
from the hold's head, and a letter's hold-free due time is the aligned
era only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@hehNervii hehNervii self-assigned this Nov 11, 2026
@hehNervii hehNervii added the bug Something isn't working label Nov 11, 2026
@hehNervii hehNervii moved this from Todo to In review in Collab!oration Nov 11, 2026
@Sparpp

Sparpp commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

feel free to ping me on dc when this is ready to merge

edit: oops sorry i see youve marked as in review

@Sparpp
Sparpp merged commit 365eaba into Sparpp:main Nov 14, 2026
1 check failed
@github-project-automation github-project-automation Bot moved this from In review to Done in Collab!oration Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants