fix: harden bootstrap and windows command resolution#22
Closed
skulidropek wants to merge 1 commit intomainfrom
Closed
fix: harden bootstrap and windows command resolution#22skulidropek wants to merge 1 commit intomainfrom
skulidropek wants to merge 1 commit intomainfrom
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- avoid bootstrap crashes when command launch errors leave stdout/stderr undefined\n- fall back to
npx -y pnpm@10.32.1 installwhencorepack/pnpmare unavailable\n- use Windows-safe command resolution in generated overlay scripts and cover it with tests\n\n## Verification\n- pnpm -C /home/dev/workspaces/spawndock/agent/repo/create test\n- pnpm -C /home/dev/workspaces/spawndock/agent/repo/create typecheck\n- pnpm -C /home/dev/workspaces/spawndock/agent/repo/create build