Repository navigation
feat(video): add selectable video codecs - #194
Draft
ReenigneArcher wants to merge 3 commits into
Draft
ReenigneArcher wants to merge 3 commits into
ReenigneArcher wants to merge 3 commits into
Conversation
4 of 21 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #194 +/- ##
==========================================
- Coverage 63.16% 62.83% -0.33%
==========================================
Files 35 33 -2
Lines 5261 5330 +69
Branches 2385 2417 +32
==========================================
+ Hits 3323 3349 +26
- Misses 935 964 +29
- Partials 1003 1017 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
ReenigneArcher
force-pushed
the
feat/decoder-choices
branch
2 times, most recently
from
May 25, 2026 16:12
0927719 to
5320639
Compare
11 of 20 tasks
ReenigneArcher
force-pushed
the
feat/decoder-choices
branch
2 times, most recently
from
June 4, 2026 23:43
c00fc4c to
5a2991d
Compare
ReenigneArcher
force-pushed
the
feat/decoder-choices
branch
4 times, most recently
from
June 24, 2026 02:52
e8326cd to
dff1ed2
Compare
ReenigneArcher
force-pushed
the
feat/decoder-choices
branch
from
November 13, 2026 01:53
dff1ed2 to
7e1f16d
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #194 +/- ##
==========================================
- Coverage 63.36% 63.31% -0.05%
==========================================
Files 37 38 +1
Lines 5333 5435 +102
Branches 2428 2463 +35
==========================================
+ Hits 3379 3441 +62
- Misses 1122 1150 +28
- Partials 832 844 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
|
ReenigneArcher
force-pushed
the
feat/decoder-choices
branch
from
November 13, 2026 02:28
7e1f16d to
738fc4b
Compare
ReenigneArcher
changed the title
ReenigneArcher
force-pushed
the
feat/decoder-choices
branch
from
November 13, 2026 04:11
bd1d409 to
0f96482
Compare
Introduce a VideoDecoderSelection setting and UI to cycle/choose preferred decoder (Auto, H.264, MPEG-2, H.263+). Persist and parse the new streaming.video_decoder setting, include it in settings initialization/persistence, and expose the choice in the settings UI and status messages. Advertise supported Moonlight video formats based on the preference and pass that to the session startup; update the FFmpeg backend to select and log the appropriate decoder (mpeg2/h263/h264), improve error messages, and expose the active decoder name to stats/overlays. Enable required FFmpeg parsers/decoders and update the ffmpeg profile signature; add/update unit tests and bump the moonlight-common-c submodule.
ReenigneArcher
force-pushed
the
feat/decoder-choices
branch
from
November 13, 2026 15:31
0f96482 to
1364172
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add H.264, MPEG-2/H.262, and H.263+ video codec selection. Auto prefers H.264, then MPEG-2, then H.263+; an explicit selection requests only that codec and fails negotiation when the host cannot provide it.
streaming.video_codec, and continue reading existingstreaming.video_decoderpreferences.Both this PR and Sunshine #5194 pin moonlight-common-c to
ed6b2da. Itsnxdk-decoder-choicesbranch is rebased onto upstream94c65fd.TODO:
Screenshot
Issues Fixed or Closed
Roadmap Issues
Testing
git diff --checkpassed.The rebase retains master's nxdk compatibility signature inputs alongside the legacy-codec FFmpeg profile. The common-library patch remains a single source-only commit, with negotiation regressions in the client's existing test suite.
An end-to-end streaming session on Xbox hardware was not run. Hosted CI results are separate from these local checks.
Type of Change
Checklist
AI Usage
See our AI usage policy.
AI tools generated much of the feature and assisted with implementation review, the shared protocol changes, settings migration, rebasing, documentation, and tests.