Repository navigation
fix(cursor): exclude outbound write skills from the read-only listing - #32
Merged
Merged
Conversation
The v1.3.2 outbound, outbound-research, and outbound-replies skills instruct write/send tools (action_card to create, approve, pause, resume, or send campaigns and prospect replies; synter_audience to build or export audiences). That breaks the free read-only Cursor Marketplace promise from the Nov 9 submission (e74fe75, v1.3.0). Move those skills to skills-write/ so the source remains available, drop them from the Cursor and Claude directory allowlists, and tighten the CI guard so they cannot ship in skills/ again. Do not merge until Joel approves. No marketplace submission in this PR.
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
An audit of Synter-Media-AI/plugin main (4a404bd, Nov 13) against the Nov 9 Cursor Marketplace submission (e74fe75, v1.3.0) found that PR #13 (v1.3.2) added three skills that break the free read-only promise.
Offending files and tools
skills/outbound/SKILL.mdinstructsaction_cardto create a drafted campaign, and to approve, pause, resume, or send; it also instructssynter_audienceto build and export audiences.skills/outbound-replies/SKILL.mdinstructsaction_cardto edit, reject, approve, and send prospect replies, and to suppress leads.skills/outbound-research/SKILL.mddoes not name those write tools, but it is the required qualification step before sending and is described as writing first-touch outreach and topping up lead lists. All three were added together and incorrectly allowlisted intools/readonly-skills.json.No other skills were added after e74fe75. Read-style company-intel tools were also added to
tools/readonly-tools.json; this PR does not remove those.What changed (minimal)
skills-write/so the source stays in the repo but is not shipped by the Cursor plugin (./skills/) or the Claude directory package.tools/readonly-skills.jsonandconfig/claude-directory/skills-allowlist.json(27 skills, matching the 1.3.1 allowlist).scripts/check-readonly-tools.jsso those skill names cannot ship underskills/again, and soaction_card/synter_audiencecannot enter the readonly tool list.packages/claude-directoryand updated package test hashes/counts.Version is still 1.3.2. No merge, tag, release, or marketplace submission in this PR.
Do not merge
Joel must approve before this is merged, per the Nov 11 stop and the request that opened this PR.
Summary by CodeRabbit