Skip to content

fix(release): build darwin-x64 natively on an Intel runner - #35

Merged
debba merged 2 commits into
masterfrom
fix/release-darwin-x64
Nov 10, 2026
Merged

debba merged 2 commits into
masterfrom
fix/release-darwin-x64

Conversation

@debba

@debba debba commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

The v0.1.0 release run failed on darwin-x64, and only there: Homebrew's installer now refuses to install an x86_64 Homebrew under Rosetta on Apple Silicon (Homebrew on macOS is only supported on Apple Silicon processors!). Without that Homebrew, the cross-compile has no unixODBC to link against. The other four targets and the EXPLAIN parser built fine. The publish job was skipped, so no 0.1.0 release exists yet.

This PR builds darwin-x64 natively on GitHub's Intel macOS runner (macos-15-intel, which has Homebrew preinstalled), the same way darwin-arm64 is built.

Test results

A temporary workflow on this PR ran the same steps on macos-15-intel and passed:

  • file: Mach-O 64-bit executable x86_64
  • otool -L: /usr/local/opt/unixodbc/lib/libodbc.2.dylib, the same library path as the 0.0.3 Intel build (Homebrew's Intel prefix)
  • initialize smoke test: {"jsonrpc":"2.0","result":null,"id":1}

I removed the temporary workflow in the second commit.

🤖 Generated with Claude Code

Homebrew's installer now refuses to install an x86_64 Homebrew under
Rosetta on Apple Silicon, so the cross-compile path for darwin-x64 could
no longer get the unixODBC it links against, and the v0.1.0 release run
failed there. The Intel macOS runner has Homebrew preinstalled and builds
the target natively, like darwin-arm64.
@debba debba added the prerelease:stable Version suggestion targets a stable release label Nov 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Version suggestion

Based on this PR's title (fix) and the prerelease:stable label:

Current 0.1.0
Suggested next tag v0.1.1

This is informational only — no tag or release is created automatically yet.

@kilo-code-bot

kilo-code-bot Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The temporary .github/workflows/tmp-darwin-x64.yml verification workflow has been removed in the latest commit, so the earlier note about it no longer applies. The remaining change in .github/workflows/release.yml builds darwin-x64 natively on macos-15-intel and replaces the Rosetta/Homebrew cross-compile steps with a single brew install unixodbc step for macOS.

Files Reviewed (1 file)
  • .github/workflows/release.yml
Previous Review Summary (commit 335d195)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 335d195)

Status: No Issues Found | Recommendation: Merge

Note: .github/workflows/tmp-darwin-x64.yml is a temporary verification workflow that the PR description says will be removed before merging. Make sure it is deleted first, as it would otherwise run on every future PR to master.

Files Reviewed (2 files)
  • .github/workflows/release.yml
  • .github/workflows/tmp-darwin-x64.yml

Reviewed by claude-sonnet-5.5 · Input: 246 · Output: 720 · Cached: 106.2K

@debba
debba merged commit 7870527 into master Nov 10, 2026
17 checks passed
@debba
debba deleted the fix/release-darwin-x64 branch November 10, 2026 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

prerelease:stable Version suggestion targets a stable release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant