Repository navigation
fix(build): resolve GNU DuckDB linking for 0.1.3 - #8
Merged
Merged
Conversation
|
Kilo Code Review could not run — your account is out of credits. Add credits or switch to a free model to enable reviews on this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hacker News v0.1.2 could not be published because its Linux ARM64 release build failed with an undefined reference to
duckdb_register_static_extensions. The other four platform builds passed. GNU ld scans the DuckDB implementation archive before the static extension registrar introduces its reference.Force that symbol to be unresolved up front on Linux GNU targets so the linker extracts its implementation. CI now builds the real plugin with GNU ld (
-fuse-ld=bfd) to cover archive ordering. Prepare v0.1.3, which includes the security updates from #7 and this build fix; v0.1.2 remains an unpublished failed release attempt.Validation:
cargo test --locked --all-targets, the local optimized release build and JSON-RPC smoke,rustfmt --check build.rs, and actionlint passed.cargo audit: zero vulnerabilities and zero warnings, without ignores.References: failed Linux ARM64 release job, GNU ld archive search and --undefined documentation.