Repository navigation
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge
Files Reviewed (3 files)
Reviewed by claude-sonnet-5.5 · Input: 248 · Output: 1.6K · Cached: 180.3K |
Version suggestionBased on this PR's title (
This is informational only — no tag or release is created automatically yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to TabularisDB/tabularis#1474 (host issue TabularisDB/tabularis#1473).
The host's
ForeignKeygains an optionalref_schema. Without it, a foreign key into another schema (billing.carry_forwards → core.organizations) makes the Related Records panel querybilling.organizationsand fail. Both FK queries already selectforeign_schema_name;row_to_foreign_keynow emits it asref_schema, soget_foreign_keys,get_all_foreign_keys_batchandget_schema_snapshotall carry it. The shape matches the built-in driver, and older hosts ignore the extra field.Validation:
live_dbtest with a cross-schema FK assertsref_schemafrom both RPCs. It fails without the change (left: Null) and passes with it.cargo clippy --all-targets -- -D warningsandcargo fmt --all -- --checkpass.parity_get_foreign_keys,parity_get_foreign_keys_composite_tableandparity_get_foreign_keys_cross_schemapass with the host change; they fail against rc.14. No new parity failures.core.organizations.