Repository navigation
perf: bundle yaml from its ES module build - #324
Conversation
🦋 Changeset detectedLatest commit: 079b577 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (2)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 079b577
☁️ Nx Cloud last updated this comment at |
commit: |
Merging this PR will improve performance by 12.94%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | reports workspace drift |
97.6 ms | 85.9 ms | +13.59% |
| ⚡ | checks a shipped skills tree |
154.4 ms | 136.6 ms | +13.05% |
| ⚡ | reports workspace drift with shared artifacts |
99.5 ms | 88.7 ms | +12.18% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing perf/bundle-yaml-esm (079b577) with main (5a0ec60)
🎯 Changes
nodeplatform, soyamlresolved to its CommonJS build, and rolldown bundled that build whole. This change aliasesyamlto the ES module build that the package serves under itsdefaultexport condition, the same way the config already handlesjsonc-parser.stalebenchmarks by 11% to 12%, thevalidatebenchmark by 9%, and thelistscan by 4%. Theloadbenchmarks and cold start are unchanged.console.warnwith a stack trace; before, it went throughprocess.emitWarning, andintent listandintent staleexited before Node printed it. TheLOG_STREAMandLOG_TOKENSenvironment variables no longer make the YAML parser print its tokens to stdout.✅ Checklist
pnpm run test:pr(runpnpm build:allfirst).🚀 Release Impact
Summary by CodeRabbit