Repository navigation
Conversation
🦋 Changeset detectedLatest commit: f2ce8fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (8)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe Svelte table app components now set table, cell, and header contexts during their own initialization. Wrappers pass the relevant values to those components. A rendering test checks wrapper output and context scope. ChangesSvelte wrapper context
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change moves context setup into the Svelte app components, so the contexts are no longer written to the parent component. No merge-blocking risk was identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #6614
🎯 Changes
The
App*wrappers fromcreateAppTablecalledsetContextbefore calling the real component, so it ran in the context of whatever component rendered<table.AppCell>. That works by accident during the parent's first render, but a cell created later (e.g. aftertoggleVisibility()on a hidden column) throwsset_context_after_initwithexperimental.async, and even without async mode the contexts land in the parent's context map.AppTable.svelte,AppCell.svelteandAppHeader.sveltenow set their context themselves while they initialize (AppTablegetstableas a prop for that), and the wrappers only add props. The context keeps the initial prop value, as before.Test: a fixture renders the four wrappers next to a probe that reads the three context keys. On
mainthe probe sees all of them; now it sees none and the wrapper children still read their contexts. I also checked the issue's case locally with a throwaway async-mode config (hidden column, thentoggleVisibility()):set_context_after_initbefore, renders after. svelte-table tests,svelte-check, eslint and prettier pass.✅ Checklist
pnpm testandpnpm test:e2e, or these tests do not apply to this pull request.🚀 Release Impact
Summary by CodeRabbit