Skip to content

fix: fix lit code example in TableLanding.tsx#708

Open
plycos wants to merge 3 commits intoTanStack:mainfrom
plycos:fix/table-landing-lit-code-example
Open

fix: fix lit code example in TableLanding.tsx#708
plycos wants to merge 3 commits intoTanStack:mainfrom
plycos:fix/table-landing-lit-code-example

Conversation

@plycos
Copy link

@plycos plycos commented Feb 11, 2026

resolves: #707

Summary by CodeRabbit

  • Refactor
    • Updated table component implementation with improved internal architecture for better maintainability.

@netlify
Copy link

netlify bot commented Feb 11, 2026

👷 Deploy request for tanstack pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit fc68ce7

@plycos plycos force-pushed the fix/table-landing-lit-code-example branch from 10fa5e0 to 9c25309 Compare February 11, 2026 23:54
@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2026

⚠️ No Changeset found

Latest commit: fc68ce7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Mar 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0db2b41f-3def-45f2-ba49-5375b6f02b32

📥 Commits

Reviewing files that changed from the base of the PR and between d9d8ab1 and fc68ce7.

📒 Files selected for processing (1)
  • src/components/landing/TableLanding.tsx

📝 Walkthrough

Walkthrough

The Lit example in the landing page component was rewritten to use a TableController-based approach instead of the non-existent createLitTable API. Imports were updated to include proper Lit decorators and utilities, with render logic refactored to initialize and display table data using the correct table controller interface.

Changes

Cohort / File(s) Summary
Landing Page Lit Example
src/components/landing/TableLanding.tsx
Replaced incorrect createLitTable API with TableController-based approach. Updated imports and refactored render logic to use tableController.table() initialization with proper table API calls (getHeaderGroups, getRowModel, getVisibleCells) and flexRender for rendering.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A hop, skip, and fix for the code on display,
Wrong imports and APIs led us astray,
TableController now shines, clean and bright,
The Lit example hops into the light!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing the incorrect Lit code example in TableLanding.tsx that was reported in the linked issue.
Linked Issues check ✅ Passed The changes directly address all requirements from issue #707: corrected imports, replaced non-existent createLitTable API with TableController-based approach, and aligned code with actual Lit/Tabla APIs.
Out of Scope Changes check ✅ Passed All changes are scoped to fixing the Lit code example in TableLanding.tsx as specified in issue #707; no unrelated modifications were introduced.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable the changed files summary in the walkthrough.

Disable the reviews.changed_files_summary setting to disable the changed files summary in the walkthrough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tanstack Table landing page Lit example under "Just a quick look..." is incorrect

1 participant