fix: 16kb 지원#858
Merged
Merged
Conversation
s9hn
reviewed
Apr 7, 2026
Member
s9hn
left a comment
s9hn
left a comment
There was a problem hiding this comment.
카카오SDK 릴리즈 노트엔 2.21.1->2로 상향되면서 16KB 및 gif관련 업데이트 사항은 없긴합니다!
카카오 로그인 sdk가 내부적으로 gif라이브러리를 쓰는건가요?
그렇지 않다면 gif라이브러리를 사용하는 상위 라이브러리를 찾아서 버전업데이트 해줘야할 것 같아요
Comment on lines
83
to
84
| // 룸 디비 제거 | ||
| // 좋아요 기능 좀더 생각해보기 |
|
|
||
| # Social Login Libraries | ||
| kakao = "2.23.1" | ||
| kakao = "2.23.2" |
| resolutionStrategy { | ||
| force("pl.droidsonroids.gif:android-gif-drawable:1.2.29") | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
버전 강제를 해버리면, 이후에 해당 라이브러리를 사용하는 sdk 혹은 상위 라이브러리에서 버전호환으로 인한 문제가 생길 수 있습니다!
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
Walkthrough앱의 풀-투-리프레시 구현을 Simform의 Changes
Sequence Diagram(s)(생성 조건에 부합하지 않아 생략) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
app/src/main/java/com/into/websoso/ui/novelFeed/NovelFeedFragment.kt (1)
362-369:⚠️ Potential issue | 🟠 Major새로고침 실패 시 스피너가 종료되지 않습니다
when분기 순서 때문에 실패 상태(error=true,loading=false)에서는 Line 368이 실행되지 않습니다. 실패 분기에서도isRefreshing = false를 명시해 주세요.수정 예시
novelFeedUiState.error -> { binding.wllNovelFeed.setLoadingLayoutVisibility(false) + binding.sptrNovelFeedRefresh.isRefreshing = false } !novelFeedUiState.loading -> { binding.wllNovelFeed.setWebsosoLoadingVisibility(false) binding.sptrNovelFeedRefresh.isRefreshing = false updateFeeds(novelFeedUiState) }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@app/src/main/java/com/into/websoso/ui/novelFeed/NovelFeedFragment.kt` around lines 362 - 369, The error branch in the when on novelFeedUiState doesn't stop the SwipeRefresh spinner because the !novelFeedUiState.loading branch (which clears binding.sptrNovelFeedRefresh.isRefreshing) is skipped when error==true; modify the error handling in NovelFeedFragment (the when handling novelFeedUiState) to also set binding.sptrNovelFeedRefresh.isRefreshing = false (or move the isRefreshing clear to run for both error and non-loading cases) along with the existing binding.wllNovelFeed.setLoadingLayoutVisibility(false) so the spinner is always stopped on refresh failure.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@app/src/main/java/com/into/websoso/ui/novelFeed/NovelFeedFragment.kt`:
- Around line 362-369: The error branch in the when on novelFeedUiState doesn't
stop the SwipeRefresh spinner because the !novelFeedUiState.loading branch
(which clears binding.sptrNovelFeedRefresh.isRefreshing) is skipped when
error==true; modify the error handling in NovelFeedFragment (the when handling
novelFeedUiState) to also set binding.sptrNovelFeedRefresh.isRefreshing = false
(or move the isRefreshing clear to run for both error and non-loading cases)
along with the existing binding.wllNovelFeed.setLoadingLayoutVisibility(false)
so the spinner is always stopped on refresh failure.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8a34d8ef-a26d-4253-bc57-0bd4fa443341
📒 Files selected for processing (4)
app/build.gradle.ktsapp/src/main/java/com/into/websoso/ui/novelFeed/NovelFeedFragment.ktapp/src/main/res/layout/fragment_novel_feed.xmlgradle/libs.versions.toml
🚧 Files skipped from review as they are similar to previous changes (1)
- app/build.gradle.kts
s9hn
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
kakao sdk가 android-gif-drawable 라이브러리를 16kb 미지원하는 버전으로 의존해서 생긴 문제라 sdk 업데이트 후 drawable 라이브러리를 강제로 업데이트 했습니다.
Summary by CodeRabbit