Repository navigation
Add viewport vision to subscription chat and research - #83
Merged
Merged
Conversation
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex sidebar requests previously sent only neutral metadata, so an image-capable model could not see the current viewport or its measurement overlays. Add an explicit Attach current view action for Chat and Research: confirm synthetic/deidentified data, inspect a removable preview, then submit one JPEG through the selected subscription model's native image input. Voice remains optional.
The backend verifies exact-model image support and bounds JPEG size, dimensions, age and owned context. Pixels remain transient; saved image receipts make submission visible in chat and research history. Stale previews, unsupported models and uncertain retries preserve the draft and avoid a second dispatch. Existing filesystem/computer tools remain disabled. One viewport is not whole-series review or clinical validation.
Validation:
gpt-6-astracorrectly described a generated colored-shape image and its visible label; a second image-plus-research turn completed with a backend PubMed call and citation. No user case image was sent.Updated owning guidance and the subscription runbook. Updating the user's currently open desktop window is tracked separately to preserve their loaded study/draft.
High-level PR Summary
This PR adds explicit viewport image attachment to Codex Chat and Research requests in the RadSysX AI sidebar. Users can preview and submit one JPEG snapshot of the active viewport (including measurement overlays) through an Attach current view action. The backend validates image support, bounds JPEG size/dimensions/age, and saves only submission receipts—never pixel data—in history. The feature works without Realtime connections and includes comprehensive validation: 233 backend tests, 52 viewer tests, 20 desktop protocol tests, plus isolated Electron smoke tests and real
gpt-6-astraacceptance with a synthetic colored-shape image.⏱️ Estimated Review Time: 15-30 minutes
💡 Review Order Suggestion
README.mdroadmap/ai-backend/CODEX_SUBSCRIPTION.mdbackend/clinical/AGENTS.mdbackend/clinical/ai_view_image.pybackend/clinical/ai_codex.pybackend/clinical/ai_text.pybackend/clinical/ai_text_routes.pypackages/clinical-web/src/contracts.tspackages/clinical-web/AGENTS.mdviewer/assets/live/protocol.tsviewer/assets/live/controller.tsviewer/assets/live/panel.tsviewer/assets/radsysx-viewer.cssdesktop/AGENTS.mdbackend/clinical/ai_evidence_routes.pybackend/clinical/ai_fixture_server.pybackend/tests/AGENTS.mdbackend/tests/test_ai_codex.pydesktop/scripts/ui-import-smoke.mjsviewer/scripts/AGENTS.mdviewer/scripts/live-contracts.tsviewer/scripts/test-live.mjsAGENTS.mdCLAUDE.mdWARP.md