Repository navigation
Document transient viewport preview detector exception - #84
Merged
Merged
Conversation
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The design detector flags the intentionally source-less image inside the hidden viewport preview. The renderer assigns the captured JPEG before display and hides it before clearing its source; native Electron vision acceptance verified successful decoding.
Record the documented, file-scoped
broken-imageexception using Impeccable's supported command. No application behavior changes. The focused detector now returns no findings;git diff --checkpasses.High-level PR Summary
This PR documents an intentional design decision by adding a linter exception for a broken-image rule. The exception covers a transient viewport preview component that deliberately starts without a source image—the component is hidden until a validated JPEG data URL is assigned, then hidden again before clearing. The change updates the
.impeccable/config.jsonfile with the exception details and records the rationale inAGENTS.mdfor future reference.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
.impeccable/config.jsonAGENTS.md