Skip to content

Document transient viewport preview detector exception - #84

Merged
TerminallyLazy merged 1 commit into
mainfrom
codex/viewport-preview-hook-exception
Sep 23, 2026
Merged

TerminallyLazy merged 1 commit into
mainfrom
codex/viewport-preview-hook-exception

Conversation

@TerminallyLazy

@TerminallyLazy TerminallyLazy commented Sep 23, 2026 •

Copy link
Copy Markdown
Owner

The design detector flags the intentionally source-less image inside the hidden viewport preview. The renderer assigns the captured JPEG before display and hides it before clearing its source; native Electron vision acceptance verified successful decoding.

Record the documented, file-scoped broken-image exception using Impeccable's supported command. No application behavior changes. The focused detector now returns no findings; git diff --check passes.

High-level PR Summary

This PR documents an intentional design decision by adding a linter exception for a broken-image rule. The exception covers a transient viewport preview component that deliberately starts without a source image—the component is hidden until a validated JPEG data URL is assigned, then hidden again before clearing. The change updates the .impeccable/config.json file with the exception details and records the rationale in AGENTS.md for future reference.

⏱️ Estimated Review Time: 5-15 minutes

💡 Review Order Suggestion
Order File Path
1 .impeccable/config.json
2 AGENTS.md

Need help? Join our Discord

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 16615b04-b40b-4164-b923-732f9cc02674


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@TerminallyLazy
TerminallyLazy merged commit 7a9cd84 into main Sep 23, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant