Repository navigation
Add scoped Codex study sharing and native viewer tools; fix logo navigation - #85
Merged
Merged
Conversation
added 10 commits
September 23, 2026 01:44
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sidebar previously shared only one viewport image. Users can now explicitly share the reading workspace or full active series with their selected ChatGPT/Codex model, and separately allow native viewer navigation and reversible edits without connecting Realtime. The logo now returns local reading to the local loader and governed/FHIR reading to the worklist, preventing navigation into OHIF's disabled study-list route.
The backend owns scoped, cancellable renderer tasks and App Server tools, with complete frame inventories, acknowledged delivery coverage, immutable action receipts, Stop/Take over and review before durable changes. Raw images remain transient. Native handlers reuse OHIF/Cornerstone services; specialized modality parity is documented as unverified.
Validation: production viewer build/type checks; focused Codex protocol tests (16 passed); isolated actual Electron/sidebar run delivered 34/34 synthetic CT frames, performed slice navigation and window/level, captured the reading grid/pane, and returned home by clicking the logo. It allocated no Realtime connection and persisted no pixels. Earlier focused contract/broker/native annotation checks are recorded in the implementation runbook. A fresh branch review found two recovery defects, both fixed. The user requested focused validation instead of further exhaustive fixture expansion.
Real subscription whole-series inference and specialized volume/fusion/ultrasound/segmentation acceptance remain open. Synthetic transport success does not establish diagnostic accuracy.
High-level PR Summary
This PR introduces comprehensive scoped Codex study exploration capabilities, enabling users to share entire reading views or complete series with their ChatGPT/Codex subscription model and operate native viewer tools independently of Realtime connections. The implementation adds a transport-independent action broker, HTTP-based task channel with renderer claims, bounded offscreen series rendering, native tool parity (navigation, measurements, annotations, segmentation), and compact sidebar UI for scope selection, activity tracking, and takeover. Images remain transient with receipt-only persistence, coverage distinguishes distinct acknowledged frame delivery from model prose, and mutations require review before durable changes. The system enforces strict boundaries: one active task per owner, 128 image deliveries/64 tool calls/10 minutes per run, 2048px/1MiB per image, with explicit continuation for partial coverage. Desktop capture handles mixed-study rejection, native calibration never invents units, and logo navigation now correctly returns to local loader or worklist. All paths preserve synthetic/deidentified pilot scope, clinical mode disablement, and existing voice/single-image behavior.
⏱️ Estimated Review Time: 1-3 hours
💡 Review Order Suggestion
backend/clinical/ai_exploration_contracts.pybackend/clinical/ai_exploration_coverage.pypackages/clinical-web/src/exploration.tsbackend/clinical/ai_actions.pybackend/clinical/ai_tools.pybackend/tests/test_ai_actions.pybackend/clinical/ai_exploration.pybackend/clinical/ai_exploration_repository.pybackend/clinical/ai_exploration_routes.pybackend/clinical/models.pybackend/tests/test_ai_exploration_routes.pybackend/tests/test_ai_exploration_lifecycle.pybackend/tests/exploration_helpers.pyviewer/assets/live/series.tsviewer/assets/live/observations.tsdesktop/src/study-capture.mjsdesktop/tests/study-capture.test.mjsdesktop/src/main.mjsdesktop/src/preload.cjsviewer/assets/live/capabilities.tsviewer/assets/live/measurements.tsviewer/assets/live/reading-tools.tsbackend/tests/test_ai_exploration_tools.pyviewer/scripts/test-exploration.mjsbackend/clinical/ai_codex_tools.pybackend/clinical/ai_codex.pybackend/tests/test_ai_codex_exploration.pybackend/clinical/ai_text.pybackend/clinical/ai_text_routes.pyviewer/assets/live/exploration.tsviewer/assets/live/exploration-panel.tsviewer/assets/live/controller.tsviewer/assets/live/panel.tsviewer/assets/live/ohif.tsviewer/assets/radsysx-viewer.cssbackend/clinical/ai_live.pybackend/clinical/ai_repository.pybackend/clinical/ai_routes.pybackend/tests/test_ai_codex.pybackend/clinical/ai_fixture_server.pydesktop/scripts/study-exploration-fixtures.pydesktop/scripts/ui-import-smoke.mjsviewer/ohif-build/study-tools.patchviewer/scripts/build-ohif-source.mjsviewer/scripts/build-ohif-dist.mjs.github/workflows/security-regressions.ymlAGENTS.mdREADME.mdbackend/clinical/AGENTS.mdbackend/requirements-ai.txtbackend/tests/AGENTS.mddesktop/AGENTS.mddesktop/package.jsondocs/AGENTS.mddocs/superpowers/plans/2026-09-23-codex-study-exploration.mddocs/superpowers/specs/2026-09-23-codex-study-exploration-design.mdpackages/clinical-web/AGENTS.mdpackages/clinical-web/src/contracts.tspackages/clinical-web/src/index.tsroadmap/AGENTS.mdroadmap/ai-backend/CODEX_STUDY_EXPLORATION.mdroadmap/ai-backend/CODEX_SUBSCRIPTION.mdroadmap/ai-backend/CODEX_VIEWER_TOOL_MATRIX.mdviewer/assets/live/AGENTS.mdviewer/assets/live/protocol.tsviewer/package.jsonviewer/scripts/AGENTS.mdviewer/scripts/live-contracts.tsdesktop/tests/live-capture.test.mjsviewer/scripts/test-live.mjsviewer/scripts/build-ohif-dist.mjs/viewer/localor/worklistinstead of/) modifies fundamental app navigation behavior in a PR focused on Codex study sharing. While mentioned in PR body, this is a separate UX concern unrelated to the study exploration feature.