Repository navigation
Fix study cancellations on native window presets and pane navigation - #88
Merged
Merged
Conversation
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Study requests repeatedly stopped on the brain window preset. The adapter indexed OHIF's preset array by a semantic name, producing an unknown action and revoking the task. Slice jumps also relied on the active pane after a potentially deferred pane switch.
Resolve configured presets by native ID/description before effects, apply their numeric values to the requested pane, and pass the explicit grid viewport to slice navigation. Wait for active-pane selection before active-dependent reading commands. Known preflight failures now return a failed tool result without cancelling the request; uncertain effects still pause, with an accurate reason.
Validation: viewer build; 64 focused viewer/controller tests; 14 backend lifecycle tests. The isolated synthetic Electron run completed series continuation/scope checks and a real two-pane test: second pane index 15, native brain preset 80/40, first pane unchanged. No patient images or new hosted-model calls. The previous single-pane/numeric-window acceptance did not exercise this defect.
Updated the owning DOX and study-exploration runbook. Unrelated .DS_Store changes excluded.
High-level PR Summary
This PR fixes two critical bugs in the OHIF viewer adapter that caused study requests to fail repeatedly: window presets were incorrectly indexed by semantic name instead of OHIF's array structure, and slice navigation relied on potentially outdated active pane state. The fix resolves presets by native ID/description before applying numeric values, passes explicit viewport references to navigation commands, and waits for active-pane selection to complete. Additionally, known preflight failures now return failed tool results without cancelling the entire request, while uncertain effects still pause with clearer messaging.
⏱️ Estimated Review Time: 15-30 minutes
💡 Review Order Suggestion
viewer/assets/live/reading-tools.tsviewer/assets/live/ohif.tsviewer/assets/live/exploration.tsviewer/scripts/test-exploration.mjsviewer/scripts/test-live.mjsbackend/clinical/ai_exploration.pydesktop/scripts/ui-import-smoke.mjsviewer/scripts/AGENTS.mdviewer/assets/live/AGENTS.mddesktop/AGENTS.mdbackend/clinical/AGENTS.mdroadmap/ai-backend/CODEX_STUDY_EXPLORATION.md