Repository navigation
Conversation
The 4.3.4.15595 client reads the two GUIDs of SMSG_SPELL_DAMAGE_SHIELD as the shield's owner and then the unit the shield struck. Its handler logs DAMAGE_SHIELD with the first GUID as the source, and it takes the damage off the second GUID's health. SpellDamageShield::Write wrote Defender (the unit that swung, Unit::DealMeleeDamage's this) first and Attacker (the victim that owns the shield) second. Every damage shield was therefore logged the wrong way round: the player who hit a Retribution Aura showed as its source, and the shield's owner as the unit it hit. Write Attacker first, as 3.3.5 does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Fix the GUID order of
SMSG_SPELL_DAMAGE_SHIELD.SpellDamageShield::WritewritesDefenderfirst andAttackersecond.Unit::DealMeleeDamagefills them as:Attacker = victim->GetGUID(): the unit that was struck in melee and owns the damage shield;Defender = GetGUID(): the unit that swung and gets hit by the shield.The 4.3.4.15595 client reads them the other way round. Its handler for the opcode reads
guid, guid, spell, damage, overkill, school, absorbedand builds theDAMAGE_SHIELDcombat log entry with the first GUID as the source and the second as the destination. The same code takes the damage off the second unit's health. So every damage shield was logged the wrong way round: the player who struck a Retribution Aura showed as the aura's source, and its owner as the one it hit.Writenow sendsAttackerfirst, which is also the 3.3.5 order (victimfirst).Tests performed: (Does it build, tested in-game, etc)
.npc add temp 44614(Training Dummy) and target it..aura 7294(Retribution Aura) on the dummy..aura 17545(Greater Holy Protection) too, if the absorb should show.DAMAGE_SHIELDwith the player as the source and the dummy as the destination..npc deletethe dummy.🤖 Generated with Claude Code