Repository navigation
Fix password generator length validation - #15757
dbhoopesh1-tech wants to merge 1 commit into
Conversation
Add validation for minimum password length requirement.
Mohit-Gaur75
left a comment
There was a problem hiding this comment.
Thanks for working on this validation!
There is an IndentationError in the if block where raise ValueError is not indented 8 spaces (4 spaces deeper than if), which is why the ruff and build CI checks are failing.
Please see the suggestion below to fix the indentation. Additionally, per the repository's contributing guidelines, consider adding a doctest to demonstrate this ValueError when i < len(chars_incl).
| if i < len(chars_incl): | ||
| raise ValueError( | ||
| "Password length must be at least the number of required characters" | ||
| ) |
There was a problem hiding this comment.
| if i < len(chars_incl): | |
| raise ValueError( | |
| "Password length must be at least the number of required characters" | |
| ) | |
| if i < len(chars_incl): | |
| raise ValueError( | |
| "Password length must be at least the number of required characters" | |
| ) |
The raise ValueError block must be indented under the if statement to avoid an IndentationError.
|
Hi, I would like to work on this issue and help get the PR into a mergeable state. Please let me know if I can take this up. Thanks! |
|
Hi @Charlie30157, thanks for offering to help! Just to clarify, this is an open Pull Request submitted by @dbhoopesh1-tech rather than an issue, so only the author (or repository maintainers) can push commits to this branch. @dbhoopesh1-tech: Are you still planning to update this PR with the indentation fix and doctest? If you're busy or unable to continue, please let us know so @Charlie30157 or another contributor can help finish it. @Charlie30157: If there's no response from the author in the next 1–2 days, feel free to open a fresh PR with the validation, proper indentation, and accompanying doctests, referencing this PR ( |
Add validation for minimum password length requirement.
Describe your change
Checklist