Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #15187.
Removes
rules.unsupported-operator = "ignore"from[tool.ty]after fixingthe seven diagnostics that were hidden by it on
masterat30507bb:Comparableprotocols usedby the iterative merge sort and the two recursive/three-way quick sorts.
Image.load()returningNoneand narrow grayscale pixel values inmean_threshold.pywithout changing the thresholding calculation.construction in the same file and avoiding a false assumption that a
BeautifulSoup attribute is statically a string.
These changes are required together to enable the rule: the isolated
unsupported-operatorcheck reports no diagnostics after the patch.Validation:
uv sync --python 3.15 --group testty checkisolated to this rule:All checks passed!ty check --exclude-scripts: nounsupported-operatordiagnosticsremain; the remaining diagnostics are pre-existing rules tracked by Tracking: complete the
tygradual-typing baseline (un-ignore rules; PEP 723 blocker astral-sh/ty#691) #15187.pytest ... --doctest-modules -q: 9 passed.grayscale images, checked the
Nonepixel-access error, and verified theextracted Amazon product link without network access.
ruff checkandruff format --check: passed.needs a
python3shim, so I ran its underlyingscripts/validate_filenames.pydirectly against the Python 3.15 environment; it passed.
git diff --check: passed.Implementation and verification were performed with Codex assistance. No
independent human review is asserted.
Describe your change
Checklist
files required to enable one
tyrule, as requested by Tracking: complete thetygradual-typing baseline (un-ignore rules; PEP 723 blocker astral-sh/ty#691) #15187.tygradual-typing baseline (un-ignore rules; PEP 723 blocker astral-sh/ty#691) #15187. It does not usea closing keyword because the tracking issue should remain open.