Repository navigation
chore: use const for the form-data loop keys in the stores - #933
Merged
edwh merged 1 commit intoOct 11, 2026
Merged
Conversation
|
edwh
added a commit
that referenced
this pull request
Oct 11, 2026
…nuxt-client The Vuex stores are deleted on this branch, and the Nuxt stores do not use the var loop keys the change fixes, so there is nothing to port. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Putting the explanation up front, as asked on #906: this comes from a small project where a local model scans open-source repos for hygiene fixes, Claude re-checks each candidate, and I review the diff before opening a PR. This one is small and mechanical.
The form-data builders in the Vuex stores loop over the params with
for (var key in params). This changes the six loops indevices.js,events.jsandgroups.jstofor (const key in params), sokeyis scoped to the loop like everything else in those functions. None of the loop bodies assign tokey, so behaviour is the same. ESLint is clean on the three files.No other
varloops are touched in this PR.