fix(view): Adjust default camera height to compensate for screen aspect ratio by Mauller · Pull Request #1711 · TheSuperHackers/GeneralsGameCode

Mauller · 2025-10-18T16:39:45Z

Merge with Rebase

Fixes: Camera height does not scale properly along with aspect ratio of game resolution #78

This PR adjusts the default max camera height to compensate for different screen aspect ratios.

Previous work fixed the vertical field of view to match retail and adjusted the horizontal fields of view.
But this resulted in significant distortion being observed in the periphery of the view and lower corners.
This distortion was also observed at the 16:9 aspect ratio and became significantly worse as the aspect ratio increased.

By maintaining the original 60 degrees horizontal field of view, while allowing the game to narrow the vertical field of view, increasing the camera height results in minimal to no distortion being observed.

~~This PR does not fix any other known camera issues and focuses on giving a playable default view.~~

TODO

Implement in generals

ElTioRata · 2025-10-18T18:34:46Z

Comparison

xezon · 2025-10-19T11:08:18Z

At 4:3 "This Change" gives identical view to "Original Game + GenTool" ✅

At 16:9 "This Change" gives a bit more view than "Original Game + GenTool" ❓

Is this correct? I do not recall if GenTool view is correct.

Mauller · 2025-10-19T11:16:50Z

At 4:3 "This Change" gives identical view to "Original Game + GenTool" ✅

At 16:9 "This Change" gives a bit more view than "Original Game + GenTool" ❓

Is this correct? I do not recall if GenTool view is correct.

My goal was to try match the vertical view as close as possible to retail, I think it's slightly less than compared to 4:3 but slightly more than 16:9 gentool + retail.

I think it has a reasonable tradeoff considering the extended horizontal view.

It also gives a reasonable view for aspect ratios between 4:3 and 1:1 as well. Giving a little more vertical view.

Under 1:1 things are still quite broken but a lot needs changing in the view handling to properly support portrait mode.

xezon · 2025-10-19T11:21:40Z

Yes GenTool did take some vertical view away to compensate for the wider view, perhaps in an attempt to keep conditions fair. Additional camera height does give a competitive advantage. Are we ok with giving advantages to Wide Screen?

Mauller · 2025-10-19T11:31:30Z

I wouldn't consider it an issue since most screens have been wide aspect For the past decade. If anything widescreen is the standard now.

Ultrawide is where it becomes more of an issue. But we could look at implementing a locked aspect mode for the tactical view in future.
This could give a standardised view to all players in a competition etc.

Or another option could be implementing tactical zoom to let people zoom out to view the entire map etc.

xezon

Simple implementation, but man the EA code is confusing.

Mauller · 2025-10-19T19:11:49Z

Tweaked the code so setDefaultView is now setDefaultCameraHeight with a default argument of 1.0f for the heightScale.

Still need to look at the zoom default handling.

Mauller · 2025-10-19T19:38:17Z

Updated with tweaked max and default zoom handling code.

Mauller · 2025-10-19T19:56:57Z

Small tweak to comments

greptile-apps

_{10 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-01-16T16:54:33Z

 /** doCameraSetDefault */
 //-------------------------------------------------------------------------------------------------
-void ScriptActions::doCameraSetDefault(Real pitch, Real angle, Real maxHeight)
+void ScriptActions::doCameraSetDefault(Real pitch, Real angle, Real heighScale)


syntax: typo: heighScale should be heightScale

Suggested change

void ScriptActions::doCameraSetDefault(Real pitch, Real angle, Real heighScale)

void ScriptActions::doCameraSetDefault(Real pitch, Real angle, Real heightScale)

Prompt To Fix With AI

This is a comment left during a code review. Path: GeneralsMD/Code/GameEngine/Source/GameLogic/ScriptEngine/ScriptActions.cpp Line: 4611:4611 Comment: **syntax:** typo: `heighScale` should be `heightScale` ```suggestion void ScriptActions::doCameraSetDefault(Real pitch, Real angle, Real heightScale) ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-01-16T16:54:34Z

 	void doCameraTetherNamed(const AsciiString& unit, Bool snapToUnit, Real play);
 	void doCameraStopTetherNamed(void);
-	void doCameraSetDefault(Real pitch, Real angle, Real maxHeight);
+	void doCameraSetDefault(Real pitch, Real angle, Real heighScale);


syntax: typo: heighScale should be heightScale

Suggested change

void doCameraSetDefault(Real pitch, Real angle, Real heighScale);

void doCameraSetDefault(Real pitch, Real angle, Real heightScale);

Prompt To Fix With AI

This is a comment left during a code review. Path: GeneralsMD/Code/GameEngine/Include/GameLogic/ScriptActions.h Line: 114:114 Comment: **syntax:** typo: `heighScale` should be `heightScale` ```suggestion void doCameraSetDefault(Real pitch, Real angle, Real heightScale); ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps

_{10 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps

_{10 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-12T18:01:39Z

 		TheTacticalView->setHeight( TheDisplay->getHeight() );
 	}
-	TheTacticalView->setDefaultView(0.0f, 0.0f, 1.0f);
+	TheTacticalView->setCameraHeightAboveGroundLimitsToDefault();


Missing setZoomToMax() call after setCameraHeightAboveGroundLimitsToDefault(). Similar to GameLogic::startNewGame() and OptionsMenu::saveOptions(), this should call setZoomToMax() to actually set the camera height.

Suggested change

TheTacticalView->setCameraHeightAboveGroundLimitsToDefault();

TheTacticalView->setCameraHeightAboveGroundLimitsToDefault();

TheTacticalView->setZoomToMax();

Prompt To Fix With AI

This is a comment left during a code review. Path: GeneralsMD/Code/GameEngine/Source/GameClient/InGameUI.cpp Line: 1380:1380 Comment: Missing `setZoomToMax()` call after `setCameraHeightAboveGroundLimitsToDefault()`. Similar to `GameLogic::startNewGame()` and `OptionsMenu::saveOptions()`, this should call `setZoomToMax()` to actually set the camera height. ```suggestion TheTacticalView->setCameraHeightAboveGroundLimitsToDefault(); TheTacticalView->setZoomToMax(); ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-12T18:01:40Z

 	TheControlBar->reset();

-	TheTacticalView->setDefaultView(0.0f, 0.0f, 1.0f);
+	TheTacticalView->setCameraHeightAboveGroundLimitsToDefault();


Missing setZoomToMax() call after setCameraHeightAboveGroundLimitsToDefault(). Without this, the camera zoom won't be properly initialized during reset.

Suggested change

TheTacticalView->setCameraHeightAboveGroundLimitsToDefault();

TheTacticalView->setCameraHeightAboveGroundLimitsToDefault();

TheTacticalView->setZoomToMax();

Prompt To Fix With AI

This is a comment left during a code review. Path: GeneralsMD/Code/GameEngine/Source/GameClient/InGameUI.cpp Line: 2150:2150 Comment: Missing `setZoomToMax()` call after `setCameraHeightAboveGroundLimitsToDefault()`. Without this, the camera zoom won't be properly initialized during reset. ```suggestion TheTacticalView->setCameraHeightAboveGroundLimitsToDefault(); TheTacticalView->setZoomToMax(); ``` How can I resolve this? If you propose a fix, please make it concise.

Mauller · 2026-03-10T13:29:42Z

This is only updating at times since i use this PR for the Legi build

seacat17 · 2026-04-07T19:02:00Z

How far are we from having this in the main build? I want to try all the new things...

xezon · 2026-05-06T18:33:31Z

I think we can go ahead with this now. Can you rebase it?

Mauller · 2026-05-06T18:40:49Z

I think we can go ahead with this now. Can you rebase it?

Sure, i will rebase and take a look back over the implementation to see if theres any tweaks i can make after your recent changes.

Mauller · 2026-05-06T18:59:25Z

Just a raw rebase on current main of the original implementation, still need to look back over it, make any suggestions.

I think i can move a lot of what i seperated out back into setdefaultview now compared to when i originaly wrote this.

…ct ratio

xezon · 2026-05-09T16:29:55Z

The scripted camera is too high.

In my opinion the height difference compared to GenTool is too much - around 3.6% difference. Especially with Control Bar Pro it will give a significant bump is viewable terrain. For starters, I suggest to set it up exactly like GenTool did.

GenTool nerfs the height by this much: const float nerf = 1.0f - (aspect - aspect_4_3) / 12.0f;

xezon · 2026-05-09T16:25:20Z

 	//	m_defaultAngle = angle * M_PI/180.0f;
 	setDefaultPitch(pitch);
-	m_maxHeightAboveGround = TheGlobalData->m_maxCameraHeight*maxHeight;
+	m_maxHeightAboveGround = TheGlobalData->m_maxCameraHeight * aspectRatioScale * maxHeight;


I expect this implementation is not correct. m_maxCameraHeight is also used in getCameraOffsetZ.

Mauller self-assigned this Oct 18, 2025

Mauller added Bug Something is not working right, typically is user facing GUI For graphical user interface Major Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour labels Oct 18, 2025

Mauller added this to the Major bug fixes milestone Oct 18, 2025

Skyaero42 reviewed Oct 18, 2025

View reviewed changes

Comment thread GeneralsMD/Code/GameEngine/Source/GameLogic/System/GameLogic.cpp Outdated

xezon added Enhancement Is new feature or request and removed GUI For graphical user interface labels Oct 19, 2025

Mauller force-pushed the fix-default-camera-height branch from 02a64e0 to 57fe78d Compare October 19, 2025 15:37

xezon reviewed Oct 19, 2025

View reviewed changes

Mauller force-pushed the fix-default-camera-height branch from 57fe78d to 271ca5b Compare October 19, 2025 19:09

Mauller force-pushed the fix-default-camera-height branch from 271ca5b to f6c96d8 Compare October 19, 2025 19:36

Mauller force-pushed the fix-default-camera-height branch from f6c96d8 to c3c7b85 Compare October 19, 2025 19:56

L3-M modified the milestones: Major bug fixes, GenTool features replication, Important features Oct 20, 2025

greptile-apps Bot reviewed Jan 16, 2026

View reviewed changes

Mauller force-pushed the fix-default-camera-height branch from a0b7db7 to 22e6c6b Compare January 28, 2026 18:25

Mauller force-pushed the fix-default-camera-height branch from 22e6c6b to 6ea3918 Compare February 9, 2026 17:57

greptile-apps Bot reviewed Feb 9, 2026

View reviewed changes

Comment thread Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DView.cpp

Mauller force-pushed the fix-default-camera-height branch from 6ea3918 to 09d7a25 Compare February 12, 2026 17:58

greptile-apps Bot reviewed Feb 12, 2026

View reviewed changes

Mauller force-pushed the fix-default-camera-height branch 2 times, most recently from b07ab06 to 499d6ef Compare February 13, 2026 14:53

ElTioRata mentioned this pull request Feb 21, 2026

Camera height does not scale properly along with aspect ratio of game resolution #78

Open

Mauller force-pushed the fix-default-camera-height branch from 499d6ef to 27aa725 Compare March 6, 2026 17:02

greptile-apps Bot reviewed Mar 6, 2026

View reviewed changes

Comment thread GeneralsMD/Code/GameEngine/Source/GameLogic/ScriptEngine/ScriptActions.cpp Outdated

Mauller force-pushed the fix-default-camera-height branch from 27aa725 to f0dc49b Compare March 22, 2026 08:39

fbraz3 mentioned this pull request Mar 24, 2026

fix(view): integrate PR1711 camera defaults and backport to Generals fbraz3/GeneralsX#47

Merged

Mauller force-pushed the fix-default-camera-height branch from f0dc49b to f5167b0 Compare April 6, 2026 13:20

Mauller force-pushed the fix-default-camera-height branch 3 times, most recently from 5617740 to a076193 Compare April 11, 2026 19:00

Mauller force-pushed the fix-default-camera-height branch from a076193 to 2523ec0 Compare April 20, 2026 15:46

Mauller force-pushed the fix-default-camera-height branch 2 times, most recently from bb8c588 to ec0c082 Compare May 4, 2026 09:15

Mauller force-pushed the fix-default-camera-height branch from ec0c082 to baa303e Compare May 6, 2026 18:58

fix(view): Adjust default camera height to compensate for screen aspe…

0813a5b

…ct ratio

Mauller force-pushed the fix-default-camera-height branch from baa303e to 0813a5b Compare May 8, 2026 09:02

xezon reviewed May 9, 2026

View reviewed changes

	void ScriptActions::doCameraSetDefault(Real pitch, Real angle, Real heighScale)
	void ScriptActions::doCameraSetDefault(Real pitch, Real angle, Real heightScale)

	void doCameraSetDefault(Real pitch, Real angle, Real heighScale);
	void doCameraSetDefault(Real pitch, Real angle, Real heightScale);

	TheTacticalView->setCameraHeightAboveGroundLimitsToDefault();
	TheTacticalView->setCameraHeightAboveGroundLimitsToDefault();
	TheTacticalView->setZoomToMax();

Conversation

Mauller commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ElTioRata commented Oct 18, 2025

Uh oh!

Uh oh!

xezon commented Oct 19, 2025

Uh oh!

Mauller commented Oct 19, 2025

Uh oh!

xezon commented Oct 19, 2025

Uh oh!

Mauller commented Oct 19, 2025

Uh oh!

xezon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Mauller commented Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mauller commented Oct 19, 2025

Uh oh!

Mauller commented Oct 19, 2025

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Mauller commented Mar 10, 2026

Uh oh!

seacat17 commented Apr 7, 2026

Uh oh!

xezon commented May 6, 2026

Uh oh!

Mauller commented May 6, 2026

Uh oh!

Mauller commented May 6, 2026

Uh oh!

xezon commented May 9, 2026

Uh oh!

xezon May 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Mauller commented Oct 18, 2025 •

edited

Loading

Mauller commented Oct 19, 2025 •

edited

Loading