Fix tests broken by a local GPU#1219
Open
brendanlong wants to merge 2 commits intoTransformerLensOrg:devfrom
Open
Fix tests broken by a local GPU#1219brendanlong wants to merge 2 commits intoTransformerLensOrg:devfrom
brendanlong wants to merge 2 commits intoTransformerLensOrg:devfrom
Conversation
Contributor
Author
|
The CI test failure seems to be caused by HuggingFace rate limiting, which is confusing since I thought you had HF_TOKEN set. Either way it's not caused by my changes and should work if you re-run them. |
jlarson4
reviewed
Apr 2, 2026
cf43c73 to
d3a844f
Compare
Tensor equality includes the device, so set device="cpu" so weight tensors always match expected, even if there's GPU they could be created on. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The test_cuda function referenced a fixture named mlm_tokens which was never defined, causing a fixture-not-found error. Changed to use the existing tokens fixture which provides the same MLM-style tokenized input. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
d3a844f to
a476e09
Compare
brendanlong
commented
Apr 3, 2026
| "unembed.b_U", | ||
| ]: | ||
| assert sd[key].device.type == cfg.device.type, f"{key} on wrong device" | ||
| assert sd[key].device.type == cfg.device, f"{key} on wrong device" |
Contributor
Author
There was a problem hiding this comment.
I had to remove .type since cfg.device is a str now. There's a pre-existing type issue here since cfg.device has type str | None so the old code shouldn't have compiled.
brendanlong
added a commit
to brendanlong/TransformerLens
that referenced
this pull request
Apr 3, 2026
This is either a torch.device or a string like "cpu", but it was typed as just `Optional[str]`. This fixes it to be `Optional[Union[str, torch.device]]` and all of the downstream places that need to be updated. Found while working on TransformerLensOrg#1219
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two of the tests fail if you have a local GPU.
test_apertusfailed because it creates CPU tensors and then compares them to tensors created on the default device. I fixed this by updating the model config to use the CPU as well.test_hooked_encoderhas a CUDA-only test (test_cuda) which expects an undefinedmlm_tokensfixture. Presumably it passes in CI because CUDA isn't available. I updated this to usetokensinstead.Before:
After:
I'm also able to run the full CI suite:
Type of change
Checklist: