Skip to content

Run theme tests on Renovate pull requests - #688

Merged
minimaluminium merged 1 commit into
mainfrom
fix/test-renovate-pull-requests
Nov 11, 2026
Merged

minimaluminium merged 1 commit into
mainfrom
fix/test-renovate-pull-requests

Conversation

@minimaluminium

Copy link
Copy Markdown
Member

Renovate PRs that update the root lockfile currently skip every theme test, while their required-check gates still pass. Run all 16 theme tests on every pull request and require a successful test result. Remove the duplicate Renovate push trigger; main-branch deployment and subtree publishing keep their existing path filters.

Validation: git diff --check passed. All 16 theme workflows will validate this PR in GitHub Actions.

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The 16 GitHub Actions workflows remove renovate/* from push branch filters and remove test-job conditions that excluded Renovate pull requests. Their required-check jobs now fail whenever test does not return success, rather than only for failed or cancelled needed jobs.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: aileen

Merge Risk: Minimal · up to 60fff

Theme tests are configured to run on Renovate pull requests and require success. No merge-blocking risk is identified.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title clearly identifies the main change: theme tests will run on Renovate pull requests.
Description check Passed The description directly explains the skipped Renovate tests, the required successful result, and the workflow trigger changes.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (16 skipped: 16 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ce96da12-71c3-4ed4-a252-5e9672993c0c
Commits

Reviewing files that changed from the base of the PR and between 93ef62c and 60fffbe.

Files selected for processing: 16

  • .github/workflows/alto.yml
  • .github/workflows/bulletin.yml
  • .github/workflows/dawn.yml
  • .github/workflows/digest.yml
  • .github/workflows/dope.yml
  • .github/workflows/ease.yml
  • .github/workflows/edge.yml
  • .github/workflows/edition.yml
  • .github/workflows/episode.yml
  • .github/workflows/headline.yml
  • .github/workflows/journal.yml
  • .github/workflows/london.yml
  • .github/workflows/ruby.yml
  • .github/workflows/solo.yml
  • .github/workflows/taste.yml
  • .github/workflows/wave.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@minimaluminium
minimaluminium merged commit 8996fe0 into main Nov 11, 2026
68 checks passed
@minimaluminium
minimaluminium deleted the fix/test-renovate-pull-requests branch November 11, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant