feat(ColumnChart): add alignLabels property#8534
Open
skythefire wants to merge 8 commits intoUI5:mainfrom
Open
feat(ColumnChart): add alignLabels property#8534skythefire wants to merge 8 commits intoUI5:mainfrom
skythefire wants to merge 8 commits intoUI5:mainfrom
Conversation
Lukas742
requested changes
May 4, 2026
Contributor
There was a problem hiding this comment.
Hi @skythefire
thanks a lot for the contribution! Please see my review below.
BarCharthardcodes'insideRight'the same way. Both are independent wrappers around recharts'BarChart(no shared base). Please addalignLabelstoBarChartas well (default'insideRight').BulletChartandComposedChartalso use theChartDataLabelcomponent. Due to the type change a typescript error is now thrown. Please adjust the types forlabelPositionin these components as well. You can check if there are build errors locally by runningyarn build.
Author
|
@Lukas742 Thanks for the review, I've addressed your comments accordingly |
Lukas742
approved these changes
May 7, 2026
Contributor
Lukas742
left a comment
There was a problem hiding this comment.
Looks good to me! 🚢
Please note that I adjusted the ChartDataLabel to filter out non-Label props. I hope that's alright :)
We will merge this PR soon and include it in our next minor release.
Author
Looks great, I realise that I misunderstood your previous comments, so all's good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3421
Thank you for your contribution! 👏
To get it merged faster, kindly review the checklist below:
Pull Request Checklist