Repository navigation
Upgrade python - #6338
Open
montplaisir wants to merge 18 commits into
Open
Upgrade python#6338montplaisir wants to merge 18 commits into
montplaisir wants to merge 18 commits into
Conversation
montplaisir
marked this pull request as ready for review
November 17, 2026 21:28
| " 'GridWorldColab.onnx',\n", | ||
| " opset_version=9,\n", | ||
| " # Use the TorchScript exporter; torch >= 2.9 defaults to dynamo, which needs onnxscript\n", | ||
| " dynamo=False,\n", |
There was a problem hiding this comment.
The training notebook’s ONNX export raises TypeError with a supported PyTorch 2.2 installation. torch.onnx.export in PyTorch 2.2 does not accept the dynamo keyword. The notebook skips installation when mlagents already imports, so an existing environment reaches this call without upgrading Torch. export_policy_model already handles older versions by inspecting the export signature. Apply the same signature check here before passing dynamo=False.
🤖 Helpful? 👍/👎
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Types of change(s)
Checklist