Skip to content

Fixing Grpc.Core.dll by removing AAA cert - #6339

Merged
Codengineer merged 5 commits into
developfrom
bobd/fix-grpc-core-dll-certs
Oct 29, 2026
Merged

Codengineer merged 5 commits into
developfrom
bobd/fix-grpc-core-dll-certs

Conversation

@Codengineer

@Codengineer Codengineer commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Proposed change(s)

Removed the AAA Certificate Services root from the TLS root list embedded in Grpc.Core.dll, following the eMudhra intermediate CA compromise.

Fix validated by Claude and manually verified using Rider Assembly Explorer.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

https://claude.ai/artifact/SaFTHbMLRsimB9WyA296pX?sk=ejupIk97nN0ySGNl7zyr5g#05456215-6d08
https://jira.unity3d.com/browse/SENTIS-1659

Types of change(s)

  • [] Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Security fix

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

Capture d’écran, le 2026-10-27 à 13 40 17

Removed the AAA Certificate Services root from the TLS root list embedded in `Grpc.Core.dll`, following the eMudhra intermediate CA compromise.
@Codengineer
Codengineer requested a review from a team as a code owner October 27, 2026 19:47

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

Ship it

The change removes the AAA Certificate Services root from the embedded gRPC certificate bundle and updates the changelog. I checked the remaining certificates, verified the assembly’s strong-name signature, and examined gRPC loading and trainer connection paths.

Reviewed commit 9cac23b

🤖 Helpful? 👍/👎

Test failed on original dll

@montplaisir montplaisir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, make sure the CI tests pass.

Codengineer and others added 3 commits October 28, 2026 13:13
Trunk's analyzer rejects AppDomain.GetAssemblies(). Get the Grpc.Core
assembly via typeof(Grpc.Core.Channel) instead, adding Grpc.Core.dll to
the editor tests asmdef's precompiled references.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Updates com.unity.inputsystem from 1.19.0 to 1.20.1 (the latest on the
registry) in both projects' manifests and lock files. PushBlockActions.cs
is regenerated by the 1.20.1 InputActionCodeGenerator.

This does not affect trunk: there the editor's built-in Input System
package overrides the manifest version.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Assets/csc.rsp applies -warnaserror+ to every assembly in Project and
DevProject, including packages. On trunk this fails the build on two
package warnings we can't fix here:

- CS0108 in the built-in Input System's DocCodeSamples.Tests/
  CreateCustomDevice.cs (MyDevice.all hides InputDevice.all)
- UAC2017 in Inference Engine's BurstCPU.Jobs.cs

Exempt both from warnings-as-errors; they still show as warnings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Codengineer
Codengineer merged commit 4649106 into develop Oct 29, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants