Repository navigation
Fixing Grpc.Core.dll by removing AAA cert - #6339
Merged
Merged
Conversation
Removed the AAA Certificate Services root from the TLS root list embedded in `Grpc.Core.dll`, following the eMudhra intermediate CA compromise.
There was a problem hiding this comment.
💡 Harness Review
The change removes the AAA Certificate Services root from the embedded gRPC certificate bundle and updates the changelog. I checked the remaining certificates, verified the assembly’s strong-name signature, and examined gRPC loading and trainer connection paths.
Reviewed commit 9cac23b
🤖 Helpful? 👍/👎
Test failed on original dll
montplaisir
requested changes
Oct 28, 2026
montplaisir
left a comment
Contributor
There was a problem hiding this comment.
LGTM, make sure the CI tests pass.
Trunk's analyzer rejects AppDomain.GetAssemblies(). Get the Grpc.Core assembly via typeof(Grpc.Core.Channel) instead, adding Grpc.Core.dll to the editor tests asmdef's precompiled references. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Updates com.unity.inputsystem from 1.19.0 to 1.20.1 (the latest on the registry) in both projects' manifests and lock files. PushBlockActions.cs is regenerated by the 1.20.1 InputActionCodeGenerator. This does not affect trunk: there the editor's built-in Input System package overrides the manifest version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Assets/csc.rsp applies -warnaserror+ to every assembly in Project and DevProject, including packages. On trunk this fails the build on two package warnings we can't fix here: - CS0108 in the built-in Input System's DocCodeSamples.Tests/ CreateCustomDevice.cs (MyDevice.all hides InputDevice.all) - UAC2017 in Inference Engine's BurstCPU.Jobs.cs Exempt both from warnings-as-errors; they still show as warnings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
montplaisir
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Removed the AAA Certificate Services root from the TLS root list embedded in
Grpc.Core.dll, following the eMudhra intermediate CA compromise.Fix validated by Claude and manually verified using Rider Assembly Explorer.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
https://claude.ai/artifact/SaFTHbMLRsimB9WyA296pX?sk=ejupIk97nN0ySGNl7zyr5g#05456215-6d08
https://jira.unity3d.com/browse/SENTIS-1659
Types of change(s)
Checklist
Other comments