Repository navigation
The selected file no longer shows a thick outline when a workspace opens - #288
Merged
Merged
Conversation
…opens Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d file when the workspace opens Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s focus ring Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…row key, as after a click Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
The selected file in Changes no longer shows the keyboard's thick outline when a workspace opens, and in the tree layout the folder lines no longer cut a pale line through the selected row.
Release note
Fixed: The selected file no longer shows a thick outline when a workspace opens
When you opened a workspace, the selected file in Changes had the keyboard's thick blue outline, as if you had moved to it with the keyboard. Now it shows once you press an arrow key, as it does after a click. In the tree layout, the folder lines no longer cut a pale line through the selected file.
Current behavior
Behavior with this pull request
On open, then after ↓ (demo sandbox, light theme):
A nested selected row in the tree layout, its guide running through it:
How it was implemented
useMainFocusfocused the main list withfocusMain's default mover,'keyboard'(a plainfocus()), and Chromium rings a script-moved focus before any input. A puremainFocusMover(reason)(app/shell/mainFocusMover.ts) now names the mover:'placeOpened'→'app'(ringless,focusAs'sfocusVisible: false),'navigated'→'keyboard'(Chromium decides, as before).waitToFocusMaintakes it.focusVisible: falsekeeps the ring off through every key until focus moves, so the hook now gives the list the keyboard's focus (blur, thenfocusAs(…, 'keyboard')) at the first key aimed at it (ringsAtKey, built onisAimedAtMainList); a click or a navigation ends that.--tree-guidewas an opaque border color painted over translucent--bg-selected/-strongrows. It's now translucent in both themes, matching the old shade on the surface (rgba(31, 35, 40, 0.08)light,rgba(240, 246, 252, 0.12)dark). Both users,ChangesList.module.cssandcomponents/FileTree.module.css, get it.cmcommands change.Behavior changes
The indent guides in every file tree (Changes, a changeset's files) darken a selected or hovered row instead of covering it; on the plain surface they look as before.
Checklist
npm run typecheckandnpm testpass. What the new tests cover:mainFocusMover(no ring when a place opens, Chromium's choice after navigating) andringsAtKey(rings at the first list key; not for chords, modifiers, focus elsewhere or a list already ringed).npm run e2epasses (one run timed out on Home while a stray debug instance of the app held the port; passed once it was closed).PlaceLayout, workspaces and repositories); file trees sharing--tree-guide.ringsAtKey), that the reason's name said "workspace" though repositories open through it too (now'placeOpened'), and asked for reviewer screenshots (above). Declined: a picture in the release note, since an "after" of an unringed row points at nothing; and moving the first docs commit into the fix's, which would rewrite history.docs/says what's now true: ARCHITECTURE.md "Focus" namesmainFocusMoverandringsAtKey.Fixed issues
None
🤖 Generated with Claude Code