Skip to content

docs: fix custom server test runner - #94

Merged
carolinerg1 merged 2 commits into
Universal-Commerce-Protocol:mainfrom
FanouZeng-TT:docs/readme-test-runner
Nov 18, 2026
Merged

carolinerg1 merged 2 commits into
Universal-Commerce-Protocol:mainfrom
FanouZeng-TT:docs/readme-test-runner

Conversation

@FanouZeng-TT

Copy link
Copy Markdown
Contributor

Description

The README's "Testing a Custom Server" example currently invokes uv run pytest with --conformance_input and --fixture_config. Those are absl.flags flags used by the individual conformance test files, not pytest options, so the documented command fails before the tests are collected.

This updates the custom-server example to use the same per-file runner pattern already used by the repository's conformance CI, passing the custom server URL, simulation secret, conformance input, and fixture config to each *_test.py file.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, including removal of schema files or fields)
  • Documentation update

Is this a Breaking Change or Removal?

N/A. This is a documentation-only update and does not remove schema files or fields.

Breaking Changes / Removal Justification

N/A.


Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Validation:

  • bash -n /tmp/conformance-readme-runner.sh
  • git diff --check
  • uvx pre-commit run --all-files

@damaz91 damaz91 added status:needs-triage Signal that the PR is ready for human triage status:under-review and removed status:needs-triage Signal that the PR is ready for human triage labels Aug 21, 2026
@damaz91 damaz91 added status:stale-review Applied if a PR is waiting on a reviewer for too long and removed status:under-review labels Sep 11, 2026
@damaz91 damaz91 added status:under-review and removed status:stale-review Applied if a PR is waiting on a reviewer for too long labels Oct 30, 2026
@carolinerg1
carolinerg1 merged commit a862e02 into Universal-Commerce-Protocol:main Nov 18, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants