Repository navigation
Conversation
damaz91
left a comment
There was a problem hiding this comment.
Thanks for putting this together, @gsmith85! Overall the workflow design, action permissions, binary checksum verification, and ucp-automation[bot] commit attribution look solid.
A quick note on current check status and sequencing:
Tests / Committed models match regeneration: failing only because this branch is based on3a86b3a(prior to #95 merging onmain). Rebasing ontomainwill clear it.- Lockfile & CLI flags dependency:
./generate_models.sh ... --channel --ref --write-lockanducp-lock.jsondepend on thefeat/ucp-lock-and-draft-channelchanges landing (while the! -f ucp-lock.jsoncheck safely skips runs in the meantime).
Left a few inline comments on rolling pull request diff/open-state handling, Prettier normalization parity with repository hooks, and branch-scoped failure issue deduplication.
b1830b5 to
edb5682
Compare
…pre-commit parity
1168ede to
7bdb7df
Compare
damaz91
left a comment
There was a problem hiding this comment.
LGTM! Thanks for addressing all the review feedback, @gsmith85—the multi-branch schedule matrix, open-pull-request and rolling ancestry guards, pre-commit Prettier parity, token isolation, and branch-scoped issue deduplication all look clean, and #98 has landed on main.
Left one optional, non-blocking nit inline that can be handled in a follow-up if needed.
| if [[ "$TARGET_BRANCH" != "main" ]] && ! git show-ref --verify --quiet "refs/remotes/origin/${TARGET_BRANCH}"; then | ||
| UPSTREAM_SHA="${REQUESTED_SHA:-$(git ls-remote https://github.com/Universal-Commerce-Protocol/ucp.git "refs/heads/${UCP_REF}" | awk '{print $1}')}" | ||
| printf '%s\n' "ISSUE_KIND=release-cut-needed" "NEW_SHA=${UPSTREAM_SHA:-unknown}" >> "$GITHUB_ENV" | ||
| exit 0 | ||
| fi |
There was a problem hiding this comment.
Optional, non-blocking nit (fine for a follow-up):
- Passing
--exit-codetogit ls-remotehere (and asserting[[ "$UPSTREAM_SHA" =~ ^[0-9a-f]{40}$ ]], matchingUniversal-Commerce-Protocol/python-sdk#107) prevents a mistypedworkflow_dispatchrelease/YYYY-MM-DDdate that does not exist upstream inucpfrom exiting0withNEW_SHA=unknownand opening a false-positiverelease-cut-neededissue. - Checking
[[ -z "$REQUESTED_SHA" || "$REQUESTED_SHA" =~ ^[0-9a-f]{40}$ ]]near the top of the step ensuresREQUESTED_SHAis validated before lines 132 and 150 writeNEW_SHAto$GITHUB_ENV.
Summary
sync-models.ymlusing a two-jobprepare->syncmatrix triggered byrepository_dispatch(ucp-schemas-updated), daily scheduled reconciliation acrossmainand activerelease/YYYY-MM-DD(>= 2026-08-25) branches, and manualworkflow_dispatchwith per-ref concurrency and job timeouts.ucp-schemainstallation, repositorypre-commitPrettier normalization, lockfile-only PR suppression (plus stale rolling PR auto-closure when models return to matching the base branch), and full build + unit test verification prior to opening or updating Stage 1 PRs viaucp-automation[bot].release-cut-neededandcodegen-sync-failureissues viaGITHUB_TOKEN, skipping duplicate comments when an open issue already references the target commit SHA.Refs Universal-Commerce-Protocol/ucp#909