Repository navigation
fix: cover ucp-agent in checkout signed request example - #907
Closed
karangoel16 wants to merge 1 commit into
Closed
karangoel16 wants to merge 1 commit into
karangoel16 wants to merge 1 commit into
Conversation
Contributor
|
Hey @karangoel16 - this is a duplicate of #795 - can you please review that instead? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #794.
The Example Signed Request in the checkout REST binding carries a
UCP-Agentheader, but itsSignature-Inputdid not coverucp-agent. The Identity Resolution Algorithm (docs/specification/overview/index.md, step 5) requires a signature to coverucp-agentwhen the header is present, and requires a verifier to skip a signature whose covered set omits it. The example therefore modeled a request a conformant implementation would not authenticate — in the place an implementer is most likely to copy from.Changes
"ucp-agent"to theSignature-Inputcovered set in the Example Signed Request (docs/specification/shopping/checkout/rest.md), matching the canonical form already used at line 515 of the same document.Checklist
source/schemas/)docs/) —docs/specification/shopping/checkout/rest.mdscripts/)docs/specification/signatures.md(Covered Components table, line 434; signing algorithm, line 462)