Skip to content

fix: cover ucp-agent in checkout signed request example - #907

Closed
karangoel16 wants to merge 1 commit into
Universal-Commerce-Protocol:mainfrom
karangoel16:fix/794-signed-example-cover-ucp-agent
Closed

karangoel16 wants to merge 1 commit into
Universal-Commerce-Protocol:mainfrom
karangoel16:fix/794-signed-example-cover-ucp-agent

Conversation

@karangoel16

Copy link
Copy Markdown
Contributor

Description

Closes #794.

The Example Signed Request in the checkout REST binding carries a UCP-Agent header, but its Signature-Input did not cover ucp-agent. The Identity Resolution Algorithm (docs/specification/overview/index.md, step 5) requires a signature to cover ucp-agent when the header is present, and requires a verifier to skip a signature whose covered set omits it. The example therefore modeled a request a conformant implementation would not authenticate — in the place an implementer is most likely to copy from.

Changes

  • Add "ucp-agent" to the Signature-Input covered set in the Example Signed Request (docs/specification/shopping/checkout/rest.md), matching the canonical form already used at line 515 of the same document.

Checklist

  • Code Changes:
    • Schema files (source/schemas/)
    • Documentation (docs/) — docs/specification/shopping/checkout/rest.md
    • Scripts or tooling (scripts/)
  • Quality & Testing:
    • Example now matches the signing algorithm in docs/specification/signatures.md (Covered Components table, line 434; signing algorithm, line 462)
    • Matches the canonical REST request example in the same document (line 515)
    • No normative text change; example count unchanged
  • Governance:
    • This is a bug fix or minor update
    • This is a new capability or breaking change (Link to Discuss RFC or Issue: #___)

@damaz91 damaz91 added the status:needs-triage Signal that the PR is ready for human triage label Oct 7, 2026
@damaz91

damaz91 commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Hey @karangoel16 - this is a duplicate of #795 - can you please review that instead? Thanks!

@damaz91 damaz91 closed this Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:needs-triage Signal that the PR is ready for human triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Example Signed Request in the checkout REST binding omits ucp-agent from its covered components

2 participants