Repository navigation
docs(signatures): cite the RFC 9421 sections that define the ECDSA raw r||s rule - #963
Merged
damaz91 merged 1 commit intoOct 26, 2026
Conversation
…w r||s rule The ECDSA bullet cites RFC 9421 section 3.3.1 for fixed-width raw r||s encoding. Section 3.3.1 is RSASSA-PSS Using SHA-512. The rule the sentence states is defined in section 3.3.4 for P-256 and section 3.3.5 for P-384, the two curves the same bullet goes on to name, and 3.3.4 states the encoding in the same terms: "These encoded values are concatenated into a single 64-octet array consisting of the encoded value of r followed by the encoded value of s." Citation only. The requirement, the encoding, the byte counts and the DER prohibition are unchanged. One site: every other RFC 9421 citation in the file resolves correctly, and the EdDSA bullet below correctly cites RFC 8032 section 5.1.6.
karangoel16
approved these changes
Oct 19, 2026
karangoel16
left a comment
Contributor
There was a problem hiding this comment.
Checked this against RFC 9421 itself, not just the PR body. §3.3.1 is RSASSA-PSS Using SHA-512 — the RFC's own registry table says so. The raw r||s rule the sentence describes lives in §3.3.4 for P-256 ("concatenated into a single 64-octet array") and §3.3.5 for P-384 (96-octet). The old citation was simply wrong.
One-line fix, nothing else to touch. Approving.
sbeashwar
approved these changes
Oct 23, 2026
sbeashwar
left a comment
Contributor
There was a problem hiding this comment.
Approving. Reviewed aa82022a
7 of 17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
signatures.mdcites RFC 9421 §3.3.1 for the ECDSA rawr||srule. §3.3.1 is RSASSA-PSS Using SHA-512. The rule the sentence states is defined in §3.3.4 for P-256 and §3.3.5 for P-384, which are the two curves the same bullet goes on to name.Observed,
docs/specification/signatures.mdL494 to L497 on maind9c18e0d:Expected, from RFC 9421 §3.3:
§3.3.4 is also where the encoding this sentence describes is specified, in the same terms: "These encoded values are concatenated into a single 64-octet array consisting of the encoded value of r followed by the encoded value of s."
This PR changes the citation only. The requirement, the encoding, the byte counts and the DER prohibition are untouched.
Scope
One site. I swept every RFC 9421 citation in the file: L362 §2.3, L367 §2.1.2, L373 §3.2.1, L382 §2.3, L387 §4.3, L671 §4.3 and L855 §3.2.1 all resolve correctly against the RFC, and the EdDSA bullet immediately below cites RFC 8032 §5.1.6, which is correct for Ed25519. L495 is the only wrong one.
The same wrong citation is present at tag
v2026-08-25(cd78fb38) and onrelease/2026-08-25. I am happy to send the branch backport separately if that is wanted; this PR targets main only.Verification
pre-commit run --files docs/specification/signatures.md: all applicable hooks Passed, exit 0. That includesvalidate-examples-changed, which needsucp-schemaon PATH; with a ucp-schema 1.4.1 binary on PATH it runs and passes rather than erroring out.markdownlint-cli0.47.0 with.github/linters/.markdownlint.json: exit 0 before and after the change, output byte identical.https://www.rfc-editor.org/rfc/rfc9421.txtrather than from memory.d9c18e0d.Note on neighbouring PRs
Six open PRs edit
signatures.md: #618, #659, #699, #782, #785 and #938. None of them touches this bullet, and a trial merge of this change against each current head is clean. I noted the same citation in a comment on #659 as outside the scope of that change.The number is also live on the published site: both https://ucp.dev/specification/signatures/ and https://ucp.dev/2026-08-25/specification/signatures/ carry it.