Repository navigation
Send sign-up to v2's app host - #2209
Closed
RhysSullivan wants to merge 1 commit into
Closed
RhysSullivan wants to merge 1 commit into
RhysSullivan wants to merge 1 commit into
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | c60f752 | Oct 08 2026, 07:04 PM |
RhysSullivan
added this pull request to stack #2208
October 8, 2026 08:51
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | c60f752 | Commit Preview URL Branch Preview URL |
Oct 08 2026, 07:04 PM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
executor
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
commit: |
RhysSullivan
force-pushed
the
cloud/v1-edge-v2-flip
branch
from
October 8, 2026 13:40
1e5d841 to
8727969
Compare
RhysSullivan
removed this pull request from stack #2208
October 8, 2026 19:00
RhysSullivan
force-pushed
the
cloud/v1-edge-v2-flip
branch
from
October 8, 2026 19:00
8727969 to
c60f752
Compare
RhysSullivan
changed the base branch from
cloud/v1-edge-v2-forward-tests
to
cloud/v1-edge-oauth-callback-tests
October 8, 2026 19:00
RhysSullivan
added this pull request to stack #2219
October 8, 2026 19:00
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1's side of the v2 host flip:
V2_SIGN_UP_URLnow points athttps://app.executor.sh/login?mode=signup, so/sign-upand/signupon executor.sh redirect to v2's sign-up page on its app host.V2service binding's Worker name is in one place inapps/cloud/wrangler.jsonc, marked as the value that must match v2.Before merging: the
V2binding'sservicemust equal the Worker name v2's deployment pins for it. Pinned name:<fill in>. Ship this only afterapp.executor.shserves v2's sign-in.Tests are in the PR above this one.