Repository navigation
Test v2's connected-account callbacks and the shipped v2 edge settings - #2212
Closed
RhysSullivan wants to merge 1 commit into
Closed
RhysSullivan wants to merge 1 commit into
RhysSullivan wants to merge 1 commit into
Conversation
RhysSullivan
added this pull request to stack #2208
October 8, 2026 08:51
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | e47a9f1 | Commit Preview URL Branch Preview URL |
Oct 08 2026, 07:02 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | e47a9f1 | Oct 08 2026, 07:03 PM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
RhysSullivan
force-pushed
the
cloud/v1-edge-oauth-callback-tests
branch
from
October 8, 2026 13:40
1ab67e3 to
ef2dce0
Compare
RhysSullivan
removed this pull request from stack #2208
October 8, 2026 19:00
RhysSullivan
force-pushed
the
cloud/v1-edge-oauth-callback-tests
branch
from
October 8, 2026 19:00
ef2dce0 to
e47a9f1
Compare
RhysSullivan
added this pull request to stack #2219
October 8, 2026 19:00
RhysSullivan
changed the title
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for the PR below: a prefixed state is forwarded with the query unchanged and no cookies, including a percent-encoded prefix and a provider error. These stay with v1: v1's raw and org-wrapped states, a missing or empty state, lookalikes (
x2abc,X2.,ax2., the prefix incodeor in another parameter, a secondstate), other paths, a posted body (never read), other hosts, and absent or broken settings. Also covers the settings parser (rejecting prefixes made only of base64url characters). The existing edge tests move to the settings object.Adds
production-config.test.ts, which readsapps/cloud/wrangler.jsoncthe way wrangler does and runs the edge with the shipped values: exactly oneV2service binding,/sign-upredirects tohttps://v2.executor.sh/login?mode=signup, and the shipped prefix isx2..