Repository navigation
Serve executor.sh marketing from v2 and keep v1's terms - #2213
Closed
RhysSullivan wants to merge 5 commits into
Closed
RhysSullivan wants to merge 5 commits into
RhysSullivan wants to merge 5 commits into
Conversation
RhysSullivan
added this pull request to stack #2208
October 8, 2026 08:51
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | ffbf496 | Oct 08 2026, 07:02 PM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | ffbf496 | Commit Preview URL Branch Preview URL |
Oct 08 2026, 07:01 PM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
RhysSullivan
force-pushed
the
cloud/v1-edge-marketing
branch
from
October 8, 2026 13:40
bcd211d to
f306c61
Compare
… its telemetry paths
RhysSullivan
removed this pull request from stack #2208
October 8, 2026 19:00
RhysSullivan
force-pushed
the
cloud/v1-edge-marketing
branch
from
October 8, 2026 19:00
5a5881e to
ffbf496
Compare
RhysSullivan
changed the base branch from
cloud/v1-edge-oauth-callback-tests
to
cloud/v1-edge-v2-flip-tests
October 8, 2026 19:00
RhysSullivan
added this pull request to stack #2219
October 8, 2026 19:00
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1's side of the marketing swap. On executor.sh the edge now forwards marketing to v2 over the
V2binding instead of proxying it toexecutor-marketing:/without awos-sessioncookie. With one,/stays v1's dashboard./x/*(everything under/x/), as v2's edge contract lists them:/home,/pricing,/pricing.md,/index.md,/setup-prompt.md,/llms.txt,/about-executor,/google-workspace,/blog,/blog/*,/docs,/docs/*,/apps,/apps/*,/experiments/*,/_astro/*,/authors/*,/og-image.pngand/pattern-graph-paper.svg.V2_ANALYTICS_PROXY_PATH(/api/<16 hex>, forwarded with everything below it) andV2_ERROR_TUNNEL_PATH(/api/<16 hex>/submit, forwarded exactly). Both are outputs of v2's production infrastructure, pinned in v2's edge contract. v1's own analytics proxy is 8 hex and stays with v1.Marketing forwards drop every cookie except v2's anonymous
executor_visitor, which keeps a visitor's homepage experiment stable; v1's session never reaches v2. Other v2 forwards still drop all cookies. Paths are not rewritten (/homegoes to v2's/home).Not forwarded:
/demoand/demo/*: an unreserved v1 organization slug. Bare/experimentsstays with v1 too (appsandexperimentsare reserved slugs in the bottom PR)./terms,/privacyand/google-oauth: v2's terms cover only v2's per-member billing, and v1's cover usage-based plans; v1's privacy policy and Google OAuth disclosure cover v1's own app. They stay onexecutor-marketing, which now builds its assets under/_v1-marketing(its PostHog proxy moves there too), so they no longer collide with v2's/_astro. TheMARKETINGbinding stays for that./setupand/api/detectwere on the old list but neither marketing site serves them./docson executor.sh is now v2's docs. The Mintlify docs proxy still serves/docson other hosts. v1's PostHog proxy is unchanged.Tests are in the PR above this one.