Repository navigation
Forward connected-account callbacks with v2's state prefix to v2 - #2218
Closed
RhysSullivan wants to merge 1 commit into
Closed
RhysSullivan wants to merge 1 commit into
RhysSullivan wants to merge 1 commit into
Conversation
RhysSullivan
added this pull request to stack #2219
October 8, 2026 19:00
Contributor
Cloudflare previewTorn down — the PR is closed. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 706f299 | Commit Preview URL Branch Preview URL |
Oct 08 2026, 07:03 PM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 706f299 | Oct 08 2026, 07:03 PM |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1 and v2 share
https://executor.sh/api/oauth/callback. v2 starts every connected-account OAuthstatewith a fixed prefix; the edge forwards a callback to v2 only when the query'sstatestarts with it. Everything else (no state, empty state, v1 state, lookalikes) stays with v1. No lookups and no body reads.V2_OAUTH_STATE_PREFIX, set tox2.. It must equal the prefix v2 mints..or~. v1's states are base64url (raw, or the org-wrapped JSON), so no v1 state can start with such a prefix.V2,V2_SIGN_UP_URL,V2_OAUTH_STATE_PREFIX), all set or none.Forwarded callbacks lose their cookies like every other v2 forward; v2 answers with a redirect to
app.executor.sh, which is returned unfollowed.Tests are in the PR above this one.
Replaces #2211, which GitHub closed when the stack was reordered.