Repository navigation
Test the error for blocked full copies - #3
Merged
RhysSullivan merged 2 commits intoOct 7, 2026
Merged
RhysSullivan merged 2 commits into
RhysSullivan merged 2 commits into
Conversation
RhysSullivan
force-pushed
the
fix/copy-all-unsearchable-dirs
branch
from
October 7, 2026 17:27
bb94532 to
be766cb
Compare
RhysSullivan
force-pushed
the
fix/copy-all-unsearchable-dirs-tests
branch
from
October 7, 2026 17:28
19e9d56 to
9dcd16f
Compare
RhysSullivan
changed the title
RhysSullivan
force-pushed
the
fix/copy-all-unsearchable-dirs-tests
branch
from
October 7, 2026 17:40
9dcd16f to
db36be3
Compare
RhysSullivan
force-pushed
the
fix/copy-all-unsearchable-dirs-tests
branch
from
October 7, 2026 18:40
db36be3 to
4cc5a8e
Compare
RhysSullivan
marked this pull request as ready for review
October 7, 2026 19:04
RhysSullivan
added a commit
that referenced
this pull request
Oct 7, 2026
* Name the entry that blocks a full copy * Keep the clone error and blame only denied entries * Do not treat an append-only destination parent as refusing * Test the error for blocked full copies (#3) * Test the error for blocked full copies * Test quoting, destination refusals, inconclusive scans and append-only parents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for the parent PR:
full_copy_names_a_directory_without_search_permission: an empty0644directory next tonode_modules. The full copy fails with an error that names the directory and suggestschmod u+x <dir>, after the kernel's original error. Nothing is created, and the source, including the directory's mode, is unchanged.full_copy_names_a_blocked_entry_inside_node_modules: an unreadable file insidenode_modulesis still found after the deferred scan.clone_errors_name_copy_on_write_only_when_it_is_unavailable:ENOSPC,EIOandEACCESreadclone failed for <path>.EXDEVandENOTSUPstayCowUnavailable.full_copy_quotes_the_suggested_command: a source path with',$, spaces and;. The suggested command runs as is under/bin/shand fixes only that directory.full_copy_does_not_blame_the_source_when_the_destination_refuses: the source has a0644directory, and the destination parent isuchg(kernelEPERM) or0555. The kernel's error is returned unchanged with nochmodhint.full_copy_keeps_the_clone_error_when_the_scan_is_inconclusive: a child process lowersRLIMIT_NOFILEso the scan hitsEMFILE. The scan reportsEMFILE, and the originalEACCESclone error is returned without blaming a healthy entry.blocked_full_copy_leaves_no_child_or_registry_row(macOS): throughManager::createwith the real APFS strategy, a blocked full copy leaves no child directory, no registry row and an unchanged source.cargo test --releasepasses on macOS/APFS.