Conversation
✅ Deploy Preview for webmonetization-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
||
| <dt><dfn>currency</dfn></dt> | ||
| <dd> | ||
| An ISO 4217 currency code (e.g. <code>"USD"</code>). |
There was a problem hiding this comment.
Not that this needs to be changed immediately, but there is the possibility of loosening the currency code requirements to be a string, not necessarily conforming to any specific ISO or other standard, though with ISO 4217 as a default. See #651 for a proposed change (which is apparently still being debated at Interledger).
|
|
||
| <dt><dfn>initial</dfn></dt> | ||
| <dd> | ||
| A decimal string representing the total budget for the current |
There was a problem hiding this comment.
Should this be in scaled currency (e.g., 1000) instead of a decimal?
There was a problem hiding this comment.
We're aligning this more with PaymentCurrencyAmount and Intl APIs, than with Open Payments.
There was a problem hiding this comment.
Let's mention these are compatible with PaymentCurrencyAmount or link to PaymentRequest/WebMonetization spec
|
|
||
| <dt><dfn>remaining</dfn></dt> | ||
| <dd> | ||
| A decimal string representing the remaining budget for the |
meyerweb
left a comment
meyerweb
left a comment
There was a problem hiding this comment.
Some thoughts on first read.
|
|
||
| <h4>Parameters</h4> | ||
| <dl> | ||
| <dt><code>callback</code></dt> |
There was a problem hiding this comment.
Nit: ReSpec supports this syntax for <code>
| <dt><code>callback</code></dt> | |
| <dt>`callback`</dt> |
| <pre class="idl"> | ||
| dictionary MonetizationInfo { | ||
| dictionary Wallet { | ||
| required DOMString address; |
There was a problem hiding this comment.
Is this the address user provided (e.g. https://sidvishnoi.com/.well-known/pay) or the resolved wallet address ID (e.g. https://ilp.gatehub.net/981946513/eur)?
| dictionary MonetizationInfo { | ||
| dictionary Wallet { | ||
| required DOMString address; | ||
| required DOMString name; |
There was a problem hiding this comment.
In Open Payments, the publicName field is optional.
There was a problem hiding this comment.
Maybe name will be empty string in those cases?
| required DOMString initial; | ||
| required DOMString remaining; |
There was a problem hiding this comment.
Should these have "balance" in their names?
| required DOMString initial; | ||
| required DOMString remaining; | ||
| DOMString? renewDate; | ||
| required boolean needsReconnect; |
There was a problem hiding this comment.
I think we discussed we might want a "reason" along with needsReconnect?
|
|
||
| <dt><dfn>initial</dfn></dt> | ||
| <dd> | ||
| A decimal string representing the total budget for the current |
There was a problem hiding this comment.
We're aligning this more with PaymentCurrencyAmount and Intl APIs, than with Open Payments.
|
|
||
| <dt><dfn>initial</dfn></dt> | ||
| <dd> | ||
| A decimal string representing the total budget for the current |
There was a problem hiding this comment.
Let's mention these are compatible with PaymentCurrencyAmount or link to PaymentRequest/WebMonetization spec
| <code>true</code> when the stored access token is invalid and the | ||
| wallet must be reconnected. |
There was a problem hiding this comment.
What happens when remaining budget is too low? Do we set needsReconnect then as well?
3 participants
No description provided.