Skip to content

feat(Step Icon): Improve default option#2290

Merged
hirokiterashima merged 9 commits intodevelopfrom
issue-2286-step-icon-defaults
Mar 25, 2026
Merged

feat(Step Icon): Improve default option#2290
hirokiterashima merged 9 commits intodevelopfrom
issue-2286-step-icon-defaults

Conversation

@hirokiterashima
Copy link
Copy Markdown
Member

@hirokiterashima hirokiterashima commented Mar 16, 2026

Currently, we assign a gray hat icon for new steps and lessons. This makes the unit feel gray and dull. This PR tries to improve this by making the unit more colorful and organized. We do this by changing the following:

  • New lesson icon will have a random color, grid icon ("dashboard" material icon)
  • New step icon will have the same color as the lesson, hat icon ("school" material icon)
    • This includes branch path steps and the merge step
  • Imported step(s) icon(s) will have the same color as lesson they get imported into, same icon as before

Test

  • Above works as described

Closes #2286

@hirokiterashima hirokiterashima self-assigned this Mar 16, 2026
@hirokiterashima hirokiterashima added the enhancement New feature of any size or improvement (UI, performance, security) label Mar 16, 2026
@qltysh
Copy link
Copy Markdown

qltysh Bot commented Mar 16, 2026

Qlty

Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (5)

RatingFile% DiffUncovered Line #s
New file Coverage rating: A
src/assets/wise5/services/authorBranchService.ts100.0%
New file Coverage rating: A
src/assets/wise5/services/createBranchService.ts100.0%
New file Coverage rating: F
src/assets/wise5/vle/node-icon/NodeIconColor.ts50.0%16
New file Coverage rating: D
src/assets/wise5/services/teacherProjectService.ts100.0%
New file Coverage rating: F
...addNode/abstract-import-step/abstract-import-step.component.ts12.5%37-61
Total52.9%
🤖 Increase coverage with AI coding...

In the `issue-2286-step-icon-defaults` branch, add test coverage for this new code:

- `src/assets/wise5/authoringTool/addNode/abstract-import-step/abstract-import-step.component.ts` -- Line 37-61
- `src/assets/wise5/vle/node-icon/NodeIconColor.ts` -- Line 16

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@hirokiterashima hirokiterashima marked this pull request as ready for review March 16, 2026 20:00
@hirokiterashima hirokiterashima requested a review from breity March 16, 2026 20:00
Copy link
Copy Markdown
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

One suggestion: If a step being imported doesn't have an icon, we should set an icon (hat and color of the lesson being imported to) for the new step. Right now, the imported step will use the hat icon and default gray color.

@hirokiterashima
Copy link
Copy Markdown
Member Author

Fixed! PTAL.

@hirokiterashima hirokiterashima requested a review from breity March 24, 2026 00:57
@hirokiterashima hirokiterashima merged commit 26269e7 into develop Mar 25, 2026
4 checks passed
@hirokiterashima hirokiterashima deleted the issue-2286-step-icon-defaults branch March 25, 2026 19:05
@hirokiterashima
Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 5.220.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature of any size or improvement (UI, performance, security) released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Step Icon): Improve default option

2 participants