Repository navigation
fix: preserve review cost-evidence contract and prepare v1.8.4 - #491
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the always-on hot-path cost evidence contract in
GD-REVIEW-008and prepare patch release v1.8.4. This directly addresses the existing failure inWibias/agent-hub'stests/skill-catalog/upstream-guidance-adoption.test.mjsafter syncing v1.8.3.Root cause
The downstream skill catalog requires both the exact methodological comparability constraint
same measurement methodand explicit p50/p95 latency metrics. Upstreamreferences/policy/reviews.mdused onlysame methodandprefer a latency distribution, so upstream tests did not detect the loss of those explicit contract elements.Changes
references/policy/reviews.md: require baseline/candidate comparisons using the same measurement method and representative inputs; report p50 and p95 latency when sample size supports meaningful percentiles; retain cold-start and unproven/insufficient-evidence safeguards.tests/unit/review-cost-evidence-contract.test.mjs: regression test asserting the downstream-required hot-path cost evidence in the policy's owning section.package.json: patch version 1.8.3 -> 1.8.4.CHANGELOG.md: dated 1.8.4 release section documenting the change.Verification
6d66c91b1c4322df8f10662e8569e0ecc5dead54: canonical Node 24 CI failed on the new focused policy-contract regression before the fix was applied.b7f7a4af15718dc4760e2e29ba3300b3273b8830: complete canonical CI passed (Node 22, Node 24, Node 26 compatibility, Windows Authority), including the new focused regression. Dependency Review, Windows trace bins, and CodeQL JavaScript/TypeScript passed. CodeQL C# is still running at the time of this update.Scope and publication
The source policy and its upstream regression are fixed here.
Wibias/agent-hubmust sync this version and rerun its own skill-catalog check to verify downstream integration. No unrelated downstream tests are changed or bypassed.Draft only. No merge, tag, GitHub Release or npm publication.