Repository navigation
fix: defer locked obsolete Authority cleanup and prepare v1.8.5 - #492
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a real Windows Approval GUI upgrade failure: with an obsolete version's
clrjit.dllheld open, v1.8.4 already committed the new GUI install record but then threw from old-version cleanup. The parent updater rolled the skill back, leaving Skill 1.8.3 / GUI record 1.8.4. A post-commit exception could also attempt to restart the previous GUI.Prepare v1.8.5. This PR does not touch
agent-hub.Changes
authority-host/windows/install-release.ps1: after committing the verified new executable, startup shortcut, and install record, obsolete version-only directories and the obsolete root launcher are removed on a best-effort basis. A locked file now produces a visible deferred-cleanup warning and is retried on the next installation.tests/windows/authority-install-obsolete-cleanup.test.ps1+.github/workflows/ci.yml: drive the real Windows PowerShell 5.1 installer while holding exclusive file handles on an obsoleteclrjit.dlland legacy launcher. Verify the new record/executable, warning, preservation of persistent state and unknown content, then successful cleanup after releasing the handles and retrying.package.json,CHANGELOG.md: bump 1.8.4 -> 1.8.5, with dated release notes.Regression evidence
21592a86532194f9b34f81284a4d6c2185685e52, Windows CI run41754021416: failure inPublish Windows authority hostfromRemove-Item ... clrjit.dllwhile an exclusive handle was held open. Node 22 / 24 passed, confirming failure in targeted Windows behavior rather than unrelated code.46d5d28dcb3714f886d00ed9d9897dabf1d820f0: full CI passed (Node 22, Node 24, Node 26 compatibility, Windows authority), including real Windows locked-file regression (Authority obsolete-file cleanup regression: PASS). The separate Authority installer retention workflow, Windows trace bins, Dependency Review, and CodeQL JavaScript/TypeScript passed. CodeQL C# is still running as of this description update.tests/windows/authority-release-retention.ps1still verifies obsolete versions are removed when no lock exists. This PR does not weaken, skip, or suppress that check.No merge, tag, GitHub Release, or npm publication requested. Keep as Draft.