Repository navigation
feat: support force-free exact-head PR publication - #493
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
[GD] Verdict: approve-commentTLDR
Full verdictSemantic propagation
UsefulnessThe change fixes the observed dead end where an exact candidate is already on the remote branch but the planner still requires a push lease. It also keeps the smaller fast-forward improvement: a proven fast-forward can publish with a plain push. Both are documented and covered by focused tests. Bugs / correctness
Security
Spec / standards
Reviews
Base / CI
Gate
|
PR-scoped grants bind authorityBranch in the signed resource and in scopeSha256, but the verdict verifier rebuilt the request without it. Merge failed with merge_review_authority_missing:review_authority_invalid:scope_mismatch even though the verdict was valid. Reconstruct the canonical scope from the signed resource and preserve the approved body byte-for-byte when appending the hidden authority marker. Legacy branch-less grants keep their old scope; inconsistent branch bindings still fail closed.
[GD] Verdict: approve-commentTLDR
Full verdictSemantic propagation
UsefulnessBefore this head, Bugs / correctness
Security
Spec / standards
Reviews
Base / CI
Gate
|
Summary
already-publishedpublication mode: when the exact candidate is already on the remote branch, the plan contains one draftcreate_prrequest and no push.headRefOidafter creation. A plan-boundpublished_headreceipt must match the lock before publication completes.--replan --reasontransition from an existing push-mode lock; it refuses when receipts exist, the pre-open scope changed, or the candidate moved.pushMode: "fast-forward": a plaingit pushonly for a proven fast-forward on an existing branch. The default lease plan is unchanged.Validation
policy-bundle --validatepasses after fixing a candidate-side size regression introduced by the earlier ordinary fast-forward rule.Safety